New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYPRESS_VERIFY_TIMEOUT ignored when passed via .npmrc #19559
Comments
2 tasks
cypress-bot
bot
added
stage: needs review
The PR code is done & tested, needs review
stage: work in progress
and removed
stage: work in progress
stage: needs review
The PR code is done & tested, needs review
labels
Jan 5, 2022
cypress-bot
bot
added
stage: pending release
and removed
stage: needs review
The PR code is done & tested, needs review
labels
Jan 12, 2022
The code for this is done in cypress-io/cypress#19560, but has yet to be released. |
2 tasks
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current behavior
When setting
CYPRESS_VERIFY_TIMEOUT
in.npmrc
it is currently ignored andVERIFY_TEST_RUNNER_TIMEOUT_MS
falls back to the default value.Desired behavior
CYPRESS_VERIFY_TIMEOUT
can also be set in.npmrc
and is picked up inverify.js
Test code to reproduce
In
.npmrc
use:Cypress Version
9.2.0
Other
@tbiethman, @emilyrohrbough: Sorry for the string to integer issue and thanks for the quick fix!
I just tested the new version today and realized the problem myself 🤦♂️
This issue here would improve the usability and handle this environment variable like I've seen in other parts in the code.
I will open another PR that will only change this line in verify.js:
Thanks for your effort and I would be happy if you could review the new pull-request 🙏
The text was updated successfully, but these errors were encountered: