Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYPRESS_VERIFY_TIMEOUT ignored when passed via .npmrc #19559

Closed
legap opened this issue Jan 5, 2022 · 2 comments · Fixed by #19560
Closed

CYPRESS_VERIFY_TIMEOUT ignored when passed via .npmrc #19559

legap opened this issue Jan 5, 2022 · 2 comments · Fixed by #19560

Comments

@legap
Copy link
Contributor

legap commented Jan 5, 2022

Current behavior

When setting CYPRESS_VERIFY_TIMEOUT in .npmrc it is currently ignored and VERIFY_TEST_RUNNER_TIMEOUT_MS falls back to the default value.

Desired behavior

CYPRESS_VERIFY_TIMEOUT can also be set in .npmrc and is picked up in verify.js

Test code to reproduce

In .npmrc use:

CYPRESS_VERIFY_TIMEOUT=100000

Cypress Version

9.2.0

Other

@tbiethman, @emilyrohrbough: Sorry for the string to integer issue and thanks for the quick fix!
I just tested the new version today and realized the problem myself 🤦‍♂️

This issue here would improve the usability and handle this environment variable like I've seen in other parts in the code.

I will open another PR that will only change this line in verify.js:

const VERIFY_TEST_RUNNER_TIMEOUT_MS = parseInt(util.getEnv('CYPRESS_VERIFY_TIMEOUT')) || 30000;

Thanks for your effort and I would be happy if you could review the new pull-request 🙏

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jan 5, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jan 12, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 12, 2022

The code for this is done in cypress-io/cypress#19560, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 18, 2022

Released in 9.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant