Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix the broken codeowners automation #19431

Merged
merged 2 commits into from Dec 20, 2021

Conversation

jennifer-shehane
Copy link
Member

I renamed the @cypress/test-runner team to @cypress/end-to-end and broke our automated code reviews based on codeowners due to this.

This fixes the codeowners so that it can trigger adding code reviewers for our team.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 20, 2021

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane merged commit 593d4b8 into develop Dec 20, 2021
@jennifer-shehane jennifer-shehane deleted the update-codeowner-team branch December 20, 2021 21:44
@cypress
Copy link

cypress bot commented Dec 20, 2021



Test summary

18909 0 218 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 48d9fec
Started Dec 20, 2021 9:42 PM
Ended Dec 20, 2021 9:53 PM
Duration 11:19 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

tgriesser added a commit that referenced this pull request Dec 21, 2021
…ert-with-stack

* tgriesser/10.0-release/refactor-lifecycle: (50 commits)
  Remove unused test file
  update task spec to use correct projectRoot
  update
  Fix test
  Fix test
  Fix tests
  update tests
  fix test
  correct config path
  Fix TS
  resolve conflicts
  Fixing component & e2e tests
  build: fix dev process on windows (#19401)
  fix: `cy.contains()` ignores `<style>` and `<script>` without removing them. (#19424)
  Fix some tests
  chore: Fix the broken codeowners automation (#19431)
  chore: add types for Cypress.session.clearAllSavedSessions (#19412)
  fix: No unnecessary snapshotting (#19311)
  chore: Remove pkg/driver @ts-nocheck part 1 (#19353)
  fix: add CYPRESS_VERIFY_TIMEOUT param and a test for it (#19282)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant