Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading a binary fixture get it's content changed #19344

Closed
andrealmieda opened this issue Dec 13, 2021 · 3 comments · Fixed by #19379
Closed

Reading a binary fixture get it's content changed #19344

andrealmieda opened this issue Dec 13, 2021 · 3 comments · Fixed by #19379
Assignees
Labels
pkg/driver This is due to an issue in the packages/driver directory type: bug type: regression A bug that didn't appear until a specific Cy version release

Comments

@andrealmieda
Copy link

Current behavior

In the process of updating from cypress@8 to cypress@9, It was noticed that intercepting a binary file had changed, making the intercepted file to be corrupted (not in the expected format).

Here's a screenshot of the update and the files diffing
Screenshot 2021-12-13 at 11 19 09

Desired behavior

When reading a binary fixture the content of it shouldn't be changed when serving it (via cy.intercept)

Test code to reproduce

https://github.com/andrealmieda/react-cypress-boilerplate

I created a small test to download the intercepted binary file and then manually check it on the terminal

Cypress Version

9.1.1

Other

No response

@emilyrohrbough
Copy link
Member

@andrealmieda Thank you for creating this issue and providing a reproducible example of the behavior you are seeing. Using your example project, I was able to re-create the issue you are seeing.

It seems this issue caused by the same regression causing #19330. The details of the regressions can found on #19330 (comment). A slight change will be needed in Cypress to maintain the previous functionality.

@emilyrohrbough emilyrohrbough self-assigned this Dec 14, 2021
@emilyrohrbough emilyrohrbough added pkg/driver This is due to an issue in the packages/driver directory type: bug type: regression A bug that didn't appear until a specific Cy version release labels Dec 14, 2021
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Dec 15, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Dec 16, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 16, 2021

The code for this is done in cypress-io/cypress#19379, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 21, 2021

Released in 9.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/driver This is due to an issue in the packages/driver directory type: bug type: regression A bug that didn't appear until a specific Cy version release
Projects
None yet
2 participants