feat: cy.selectFile() #19332

BlueWinds · 2021-12-10T17:31:36Z

Closes Adding Ability to Submit File to Input Element From Local Filesystem (file upload) #170

User facing changelog

Adds native support for .selectFile(), allowing interaction with file input elements as well as simulating a user drag-dropping files over the document.

cy.get('input[type="file"]').selectFile('cypress/fixtures/myfixture.json');

The API is similar to cypress-file-upload, and we have provided a migration guide for previous users of that plugin.

For full details, see the .selectFile() documentation.

Additional details

The documentation and migration guide contain extensive information about all the options and features of this new command.

PR Tasks

Have tests been added/updated?
Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
Has a PR for user-facing changes been opened in cypress-documentation? cy.selectFile docs cypress-documentation#4241
Have API changes been updated in the type definitions?
[N/A] Have new configuration options been added to the cypress.schema.json?

cypress-bot · 2021-12-10T17:31:38Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

BlueWinds · 2021-12-10T17:39:39Z

Moving to draft temporarily while I get the tests passing. Documentation / code wise, I don't expect much to change here, just have to fix a couple things that came up from merging in 10.0-release.

cypress · 2021-12-10T17:54:13Z

Test summary

18419 • 0 • 218 • 0 • 3

Run details


Project	cypress
Status	Passed
Commit	`4e3559c`
Started	Dec 20, 2021 9:40 PM
Ended	Dec 20, 2021 9:52 PM
Duration	11:56 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

Flakiness

	commands/net_stubbing_spec.ts	2
1	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
	cypress/proxy-logging-spec.ts	1
1	Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

BlueWinds · 2021-12-14T19:53:33Z

Ok, tests fixed (only remaining failure is flake in the 10.0-release branch, nothing to do with this PR).

AtofStryker

Integration tests look to cover multiple use cases as well as most error states. Docs looks ready to go and the system test on 3rd party integrations looks really nice. I also found the code fairly easy to follow and a lot of the provided comments really helped shed clarity on some areas. Great work 🎉 !

packages/driver/cypress/integration/commands/actions/attachFile_spec.js

packages/driver/src/cy/commands/actions/index.ts

system-tests/package.json

packages/driver/src/cy/commands/actions/attachFile.ts

AtofStryker

Looks good! Guessing the net_stubbing_spec is currently a little flaky. I had some issues getting the tests to pass consistently locally, but if I am wrong about that lmk! Changes here look unrelated.

cli/types/cypress.d.ts

jennifer-shehane · 2021-12-17T19:39:01Z

cli/types/cypress.d.ts

+     * Attach a file to the given <input> element, or drag and drop a file over any subject.
+     *
+     * @param {FileReference} files - The file(s) to attach or drag onto this element.
+     * @see https://on.cypress.io/selectFile


Has this on link been created on Services? I think this is also meant to be all lowercaps to reroute correctly.

Suggested change

* @see https://on.cypress.io/selectFile

* @see https://on.cypress.io/selectfile

It hasn't been added yet - I'll open a PR to do that, thanks for the reminder.

I'm lowercasing the link for consistency, but worth noting that URLs are almost universally case insensitive on all modern systems. This isn't given in any spec, and it's not universally true, but in most cases it is.

https://docs.cypReSS.io/api/cOmMaNdS/wItHiN

(let's never actually do this, just an interesting note)

https://github.com/cypress-io/cypress-services/pull/4174 has been merged in.

packages/driver/cypress/integration/commands/actions/selectFile_spec.js

BlueWinds · 2021-12-21T17:52:19Z

Only test failure is unrelated, an issue with circleci and pulling dockerhub images. I think we're about ready to merge into 10.0-release, so that I can start on the backport into develop?

* feat: cy.attachFile with passed-in contents (#18825) * feat: attachFile string shorthands (#19045) * feat: Add drag-n-drop support (#19213) * Remove cypress-file-upload

cypress-bot · 2022-06-01T15:48:04Z

Released in 10.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.0.0, please open a new issue.

Blue F and others added 6 commits November 22, 2021 10:37

feat: cy.attachFile with passed-in contents (#18825)

8e50f93

Merge remote-tracking branch 'origin/develop' into feat/attach-file

1c64d5c

Merge remote-tracking branch 'origin/develop' into feat/attach-file

5c43ebb

feat: attachFile string shorthands (#19045)

e9592c5

feat: Add drag-n-drop support (#19213)

8f683a6

Merge remote-tracking branch 'origin/10.0-release' into feat/attach-file

be13d76

BlueWinds requested a review from cowboy December 10, 2021 17:31

Move attachFile system test config to .js file

f331003

BlueWinds marked this pull request as draft December 10, 2021 17:38

BlueWinds added 5 commits December 10, 2021 11:22

Merge remote-tracking branch 'origin/10.0-release' into feat/attach-file

86afa12

Remove cypress-file-upload

b172db0

Fix test path

f0979f7

More test fixes, for real this time

80a4162

Merge remote-tracking branch 'origin/10.0-release' into feat/attach-file

39771b9

BlueWinds marked this pull request as ready for review December 14, 2021 19:52

BlueWinds mentioned this pull request Dec 14, 2021

[Feature] Cypress adding native attach file support in 9.3.0 abramenal/cypress-file-upload#338

Closed

AtofStryker previously approved these changes Dec 14, 2021

View reviewed changes

Review tweaks

e47debd

BlueWinds dismissed AtofStryker’s stale review via e47debd December 15, 2021 17:52

jennifer-shehane mentioned this pull request Dec 15, 2021

feat(breaking): 10.0 Release #18924

Merged

AtofStryker self-requested a review December 15, 2021 19:31

AtofStryker previously approved these changes Dec 15, 2021

View reviewed changes

BlueWinds added 2 commits December 17, 2021 09:50

Rename attachFile -> selectFile

d1b1c54

Merge remote-tracking branch 'origin/10.0-release' into feat/attach-file

1ae746e

BlueWinds dismissed AtofStryker’s stale review via 1ae746e December 17, 2021 17:55

BlueWinds changed the title ~~feat: cy.attachFile()~~ feat: cy.selectFile() Dec 17, 2021

jennifer-shehane requested changes Dec 17, 2021

View reviewed changes

BlueWinds and others added 2 commits December 17, 2021 12:28

Reword type help, update test titles

b4ce153

Merge branch '10.0-release' into feat/attach-file

4e3559c

BlueWinds requested review from jennifer-shehane and AtofStryker December 20, 2021 21:41

AtofStryker approved these changes Dec 21, 2021

View reviewed changes

jennifer-shehane approved these changes Dec 22, 2021

View reviewed changes

BlueWinds merged commit 6d10a7f into 10.0-release Dec 22, 2021

BlueWinds deleted the feat/attach-file branch December 22, 2021 17:03

cypress-bot bot mentioned this pull request Dec 22, 2021

Adding Ability to Submit File to Input Element From Local Filesystem (file upload) #170

Closed

BlueWinds pushed a commit that referenced this pull request Jan 3, 2022

feat: cy.selectFile() (#19332)

ba2d830

* feat: cy.attachFile with passed-in contents (#18825) * feat: attachFile string shorthands (#19045) * feat: Add drag-n-drop support (#19213) * Remove cypress-file-upload

jennifer-shehane pushed a commit that referenced this pull request Jan 14, 2022

feat: cy.selectFile() (#19332) (#19524)

3809cd4

cypress-bot bot locked as resolved and limited conversation to collaborators Jun 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cy.selectFile() #19332

feat: cy.selectFile() #19332

BlueWinds commented Dec 10, 2021 •

edited

cypress-bot bot commented Dec 10, 2021

BlueWinds commented Dec 10, 2021

cypress bot commented Dec 10, 2021 •

edited

BlueWinds commented Dec 14, 2021

AtofStryker left a comment

AtofStryker left a comment

jennifer-shehane Dec 17, 2021

BlueWinds Dec 17, 2021

BlueWinds Dec 20, 2021 •

edited

BlueWinds commented Dec 21, 2021

cypress-bot bot commented Jun 1, 2022

	* @see https://on.cypress.io/selectFile
	* @see https://on.cypress.io/selectfile

feat: cy.selectFile() #19332

feat: cy.selectFile() #19332

Conversation

BlueWinds commented Dec 10, 2021 • edited

User facing changelog

Additional details

PR Tasks

cypress-bot bot commented Dec 10, 2021

BlueWinds commented Dec 10, 2021

cypress bot commented Dec 10, 2021 • edited

Test summary

Run details

Flakiness

BlueWinds commented Dec 14, 2021

AtofStryker left a comment

Choose a reason for hiding this comment

AtofStryker left a comment

Choose a reason for hiding this comment

jennifer-shehane Dec 17, 2021

Choose a reason for hiding this comment

BlueWinds Dec 17, 2021

Choose a reason for hiding this comment

BlueWinds Dec 20, 2021 • edited

Choose a reason for hiding this comment

BlueWinds commented Dec 21, 2021

cypress-bot bot commented Jun 1, 2022

BlueWinds commented Dec 10, 2021 •

edited

cypress bot commented Dec 10, 2021 •

edited

BlueWinds Dec 20, 2021 •

edited