Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maxHttpBufferSize for socket.io server to allow larger messages to be sent #19140

Closed
tbiethman opened this issue Nov 29, 2021 · 2 comments · Fixed by #19015
Closed
Assignees

Comments

@tbiethman
Copy link
Contributor

What would you like?

Socket.io's server uses a default value of 1MB for its maxHttpBufferSize option to reduce exposure to denial of service attacks. Cypress sets a value of 100MB today to match a previous default value and maintain passivity.

The max value should be increased to reduce the chance of reaching the limit. Documentation should also be added make the limit explicitly known, whether we increase it or not. The documentation may make the most sense around the readFile/writeFile commands and other commands where size may be a concern.

Why is this needed?

The current 100MB value seems arbitrary. Given that DoS attacks aren't a concern for our local server, we should be able to increase this value to the maximum supported value and ensure this isn't a limitation for users.

Other

The maxHttpBufferSize will be bounded by Buffer's maximum size.

This was originally investigated as part of #3350.

@tbiethman tbiethman self-assigned this Nov 29, 2021
@cypress-bot cypress-bot bot added stage: icebox stage: needs review The PR code is done & tested, needs review and removed stage: to do labels Dec 3, 2021
@tbiethman tbiethman linked a pull request Dec 7, 2021 that will close this issue
4 tasks
@tbiethman tbiethman added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Dec 7, 2021
@tbiethman
Copy link
Contributor Author

tbiethman commented Dec 7, 2021

The code for this is done in #19015, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 21, 2021

Released in 9.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant