fix: test config overrides leak for .only execution #18961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
emilyrohrbough
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
emilyrohrbough
requested review from
jennifer-shehane
and removed request for
a team
flotwig
reviewed
Nov 17, 2021
Comment on lines
36
to
52
| systemTests.it(`correctly applies overrides when valid configuration for describe.only`, { | ||
| spec: 'testConfigOverrides-describe-only-valid.js', | ||
| snapshot: true, | ||
| expectedExitCode: 0, | ||
| config: { | ||
| video: false, | ||
| }, | ||
| }) | ||
|
|
||
| systemTests.it(`correctly applies overrides when valid configuration for it.only`, { | ||
| spec: 'testConfigOverrides-it-only-valid.js', | ||
| snapshot: true, | ||
| expectedExitCode: 0, | ||
| config: { | ||
| video: false, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
I think these don't need to be system tests, they can be regular driver Cypress tests instead, right? Since we run one test file at a time in cypress run, it should work the same. packages/driver/cypress/integration/e2e would be a good place.
Avoid adding system tests if possible since they're a lot heavier, resource-wise. And since we're just running the test and the snapshot doesn't have any additional info in it, it should be fine to make these regular Cypress tests.
There was a problem hiding this comment.
hmmm good point. Updated: 96e4e80 (#18961)
davidmunechika
approved these changes
Nov 22, 2021
flotwig
approved these changes
Nov 22, 2021
tgriesser
added a commit
that referenced
this pull request
Nov 28, 2021
* develop: test: node_modules installs for system-tests, other improvements (#18574) chore(deps): update dependency semantic-release to v17.2.3 [security] (#19022) chore: remove flaky ci jobs for main builds (#19071) chore(contributing): clarify PULL_REQUEST_TEMPLATE (#19068) fix: the shadow root container element is ignored when clicking an element in it. (#18908) 'Fix' flaky redirect test (#19042) release 9.1.0 [skip ci] fix: Allow 'this' to be used in overridden commands (#18899) fix(react): link to rerender example (#19020) chore(deps): update dependency aws-sdk to v2.814.0 [security] (#18948) fix: test config overrides leak for .only execution (#18961) feat: Set CYPRESS=true as env var in child processes where Cypress runs user code in Node (#18981) fix: Restore broken gif (#18987) chore: release @cypress/vite-dev-server-v2.2.1
lmiller1990
pushed a commit
that referenced
this pull request
Nov 29, 2021
tgriesser
added a commit
that referenced
this pull request
Nov 29, 2021
* 10.0-release: feat(graphql): ability to update/query for appData (#19082) fix system test fix failing tests due to merge resolve conflicts test: node_modules installs for system-tests, other improvements (#18574) update yarn.lock chore(deps): update dependency semantic-release to v17.2.3 [security] (#19022) chore: remove flaky ci jobs for main builds (#19071) chore(contributing): clarify PULL_REQUEST_TEMPLATE (#19068) fix: the shadow root container element is ignored when clicking an element in it. (#18908) 'Fix' flaky redirect test (#19042) release 9.1.0 [skip ci] fix: Allow 'this' to be used in overridden commands (#18899) fix(react): link to rerender example (#19020) chore(deps): update dependency aws-sdk to v2.814.0 [security] (#18948) fix: test config overrides leak for .only execution (#18961) feat: Set CYPRESS=true as env var in child processes where Cypress runs user code in Node (#18981) fix: Restore broken gif (#18987) chore: release @cypress/vite-dev-server-v2.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent change to add configuration validation required updates to include the invocation details to throw an invalidation configuration error with the correct line number of where the configuration was passed in for suite/test configuration. These changed did not account for single suite/test execution which was normalized more than once.
How has the user experience changed?
The configuration appears to have been applying correctly, so should be minimal to no impact on consumers.
PR Tasks