fix: Allow 'this' to be used in overridden commands #18899
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this
context can't be overwritten #18892User facing changelog
Cypress commands that rely on
this
can now be overridden cleanly,Additional details
Previously, there was no clean way to invoke an overridden command that, for example, read the test title:
I don't believe this requires any change in the documentation - it's a fairly niche limitation for command authors. This just makes our API work as you would expect if familiar with JS, instead of having an unexpected limitation. There was no particularly good reason for this limitation, and removing it is easy.
PR Tasks