Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type checker #18069

Closed
sainthkh opened this issue Sep 13, 2021 · 1 comment · Fixed by #18172
Closed

Fix type checker #18069

sainthkh opened this issue Sep 13, 2021 · 1 comment · Fixed by #18172
Assignees
@sainthkh
Labels
topic: typescript type: chore Work is required w/ no deliverable to end user

Comments

@sainthkh
Copy link
Contributor

Current behavior

scripts/type_checker.js doesn't check types. I guess it was broken after listr2 update at #16663.

Desired behavior

Type checking should work.

Test code to reproduce

yarn type_check will fail although you can find various errors in the .ts files.

Cypress Version

8.3.1

Other

No response
@sainthkh sainthkh self-assigned this Sep 13, 2021
@sainthkh sainthkh added type: chore Work is required w/ no deliverable to end user topic: typescript stage: ready for work The issue is reproducible and in scope labels Sep 13, 2021
@jennifer-shehane
Copy link
Member

oh no 😞

@sainthkh sainthkh mentioned this issue Sep 21, 2021
Merged
4 tasks
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Sep 21, 2021
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 1, 2021
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Oct 11, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 13, 2021
@cypress-io cypress-io deleted a comment from cypress-bot bot Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sainthkh sainthkh

Labels
topic: typescript type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: revive type checker sainthkh/cypress
3 participants
@flotwig @jennifer-shehane @sainthkh