Skip to content

Missing types for clientCertificate #17799

Closed
@lmiller1990

Description

@lmiller1990
Contributor

Current behavior

There is a clientCertificates option. https://docs.cypress.io/guides/references/client-certificates#Syntax

It should include in the type definitions: https://github.com/cypress-io/cypress/blob/develop/cli/types/cypress.d.ts#L2491

Desired behavior

Included in types.

Test code to reproduce

const C: Cypress.ResolvedConfigOptions = {
  clientCertificates: // <- no completion or hint
}

Cypress Version

8.0.0

Other

This is a good first issue for a new contributor or a new employee. Although adding the type is simple enough, it's a good way to learn how to set up Cypress locally, make a PR, get a review, etc. Let's encourage a new contributor to take this one.

Activity

Jayita10

Jayita10 commented on Aug 19, 2021

@Jayita10

I want to work on this issue

JessicaSachs

JessicaSachs commented on Aug 19, 2021

@JessicaSachs
Contributor

I want to work on this issue

Go for it @Jayita10. Do you need anything?

Jayita10

Jayita10 commented on Aug 19, 2021

@Jayita10

Hi, I'm not able to understand the type definitions part, How should I proceed with this

JessicaSachs

JessicaSachs commented on Aug 19, 2021

@JessicaSachs
Contributor

You'd need to open the file Lachlan linked and add the types for the clientCertificate field. There are examples in that file.

Et-008

Et-008 commented on Aug 25, 2021

@Et-008

Hi, is this issue still open?
if yes, I'd like to work on it, thanks.

jennifer-shehane

jennifer-shehane commented on Aug 25, 2021

@jennifer-shehane
Member
aashish0909

aashish0909 commented on Sep 8, 2021

@aashish0909

Hey, is this issue still open?

lmiller1990

lmiller1990 commented on Sep 9, 2021

@lmiller1990
ContributorAuthor

@aashish0909 the work has been completed in #18028 so it will be closed soon and marked as done.

If you are looking for some good first issues, I can probably tag you in a few, if you like.

aashish0909

aashish0909 commented on Sep 9, 2021

@aashish0909

@lmiller1990 Yeah, please do. It will be really helpful.

1 remaining item

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersstage: needs reviewThe PR code is done & tested, needs reviewtype: typingsIssue related to Cypress types (for TypeScript)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @jennifer-shehane@JessicaSachs@lmiller1990@aashish0909@Et-008

      Issue actions

        Missing types for clientCertificate · Issue #17799 · cypress-io/cypress