feat: ignore non-letters in specs list filter #17346
Merged
+77
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papermana
requested review from
flotwig and
chrisbreiding
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
papermana
changed the title
|
Seems like the tests are not passing after all. Will resolve it and open the PR again. |
papermana
changed the title
|
Some tests are still failing, but they seem to be different every time I make a change. Are they just naturally flaky, or does it mean that something's wrong? I don't think my changes are related to Electron etc. Anyway, I'm opening the PR again. Not sure if I should re-request review. @jennifer-shehane? |
|
Hey @papermana, thanks for the work. We'll review as soon as we can. We're a little tied up today getting our release out. Thanks! |
jennifer-shehane
previously approved these changes
Jul 21, 2021
chrisbreiding
approved these changes
Jul 21, 2021
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
When filtering specs in the desktop client, characters that are not letters will be ignored and don't have to be typed.
Additional details
The logic for filtering the specs list is very strict currently, and you have to type in the name of the desired spec(s) exactly. Ideally, filtering would use fuzzy logic, but I can see that at least one PR included that, and the fuzzy search feature was removed because of some issues.
A low hanging fruit type of solution is simply ignoring certain characters. Having to type every "_" has been the biggest problem in my experience, so this should already make things more convenient.
I used a nifty newish regexp feature to detect all letter characters, including non-Latin ones. (I don't think it would be OK to break the search function for people using different writing systems.) You can see an explanation here.
Note that this change will also ignore any digits. Of course, that can be changed.I decided numbers should also be kept.Small warning: I can't get dependencies to install on my M1 Macbook (Electron doesn't want to build), so I haven't tested this code myself. I'm hoping the E2E tests will pass.
How has the user experience changed?
Before: to find
user_profile.spec, I have to type "user_prof".After: I can type "userprof".
PR Tasks