-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat: updated record run instructions #17317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…to record-run-0-state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panzarino Can you resolve the conflicts and merge in develop. Will make this easier to test with the new project being fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panzarino When I set up a run to record, the record key doesn't populate on this screen. If I change tabs and come back to the Runs tab - it does populate the record key. I tried to fix some conflicts from develop around getting the record key so it's possible I may have introduced this myself.
@jennifer-shehane I'm struggling to reproduce - do you have more specifics on when this occurs? From looking at the code I don't see any problems and I've tried a couple different workflows to try to get it to happen |
@panzarino Sorry for the delay in replying. This is what I did:
I've attached a gif below of the behavior. |
@jennifer-shehane So I still wasn't able to reproduce by following those exact steps but I did realize that I had accidentally slightly changed some of the logic around when to load the record key. I've reverted back to the original working version that we had (before this PR) which should fix the issue you were experiencing (and also fixes a memory leak error). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the record key populates now like it used it.
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Requires https://github.com/cypress-io/cypress-services/pull/3909 to be deployed with
on
link changes before this can be mergedUser facing changelog
Additional details
We've added a new record run instructions screen for some users - using the same method of A/B testing as on the dashboard (by
orgId
) we hope to trial A/B tests in the TR. We'll be able to track whether or not this leads to an increased percentage of new orgs that end up recording runs to the dashboard. The new screen is similar to our current dashboard 0 state which showed a much better rate of recording runs along with helpful links in the cards at the bottom.How has the user experience changed?
New (test group)
Old (control group)
PR Tasks