Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #17132 use hoisted yarn install in build binary #17215

Merged
merged 1 commit into from Jul 6, 2021

Conversation

tgriesser
Copy link
Member

Reverts #17132

Need to fix the Mac signing & issues with the Windows build

@tgriesser tgriesser requested a review from a team as a code owner July 6, 2021 20:28
@tgriesser tgriesser requested review from jennifer-shehane and kuceb and removed request for a team July 6, 2021 20:28
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 6, 2021

Thanks for taking the time to open a PR!

@tgriesser tgriesser changed the title Revert merge #17132 "chore: use hoisted yarn install in build binary" Revert "[merge] chore: use hoisted yarn install in build binary" Jul 6, 2021
@tgriesser tgriesser changed the title Revert "[merge] chore: use hoisted yarn install in build binary" fix: revert #17132 use hoisted yarn install in build binary Jul 6, 2021
@tgriesser tgriesser merged commit ca44464 into develop Jul 6, 2021
@tgriesser tgriesser deleted the revert-17132-tgriesser/chore/root-yarn-install branch July 6, 2021 20:30
@cypress
Copy link

cypress bot commented Jul 6, 2021



Test summary

18185 0 214 7Flakiness 4


Run details

Project cypress
Status Passed
Commit 11f9d22
Started Jul 6, 2021 8:31 PM
Ended Jul 6, 2021 8:42 PM
Duration 11:36 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes
commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > should delay the same amount on every response
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
3 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant