Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken default reporter resizer #17214

Merged
merged 2 commits into from Jul 6, 2021

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Jul 6, 2021

User facing changelog

n/a - fix for a bug in develop

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@kuceb kuceb requested a review from a team as a code owner July 6, 2021 20:09
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 6, 2021

Thanks for taking the time to open a PR!

@kuceb kuceb requested review from chrisbreiding and jennifer-shehane and removed request for a team July 6, 2021 20:09
@jennifer-shehane
Copy link
Member

jennifer-shehane commented Jul 6, 2021

I see the issue now. You can't resize the reporter at all when your appData has no reporterWidth. Very strange. Checking the PR now for the fix.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resizing the reporter works with the change in this PR.

@cypress
Copy link

cypress bot commented Jul 6, 2021



Test summary

18185 0 214 7Flakiness 2


Run details

Project cypress
Status Passed
Commit ebd8a97
Started Jul 6, 2021 8:36 PM
Ended Jul 6, 2021 8:47 PM
Duration 11:00 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane merged commit 7fbc617 into develop Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command log resizer broken
3 participants