Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack-preprocessor: Add webpack 5 as peerDependency #16947

Closed
WIStudent opened this issue Jun 15, 2021 · 2 comments · Fixed by #15611
Closed

webpack-preprocessor: Add webpack 5 as peerDependency #16947

WIStudent opened this issue Jun 15, 2021 · 2 comments · Fixed by #15611
Labels
npm: @cypress/webpack-preprocessor @cypress/webpack-preprocessor package issues type: unexpected behavior User expected result, but got another

Comments

@WIStudent
Copy link

Experimental support for webpack 5 was added in #16493, but the peerDependency in package.json currently only allows weback 4, resulting in the following error when trying to install webpack-preprocessor together with webpack 5 using npm@7:

$ npm install --save-dev @cypress/webpack-preprocessor
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: my-project@1.0.0
npm ERR! Found: webpack@5.39.0
npm ERR! node_modules/webpack
npm ERR!   dev webpack@"^5.39.0" from the root project
npm ERR!   peer webpack@">=2" from babel-loader@8.2.2
npm ERR!   node_modules/babel-loader
npm ERR!     dev babel-loader@"^8.2.2" from the root project
npm ERR!     peer babel-loader@"^8.0.2" from @cypress/webpack-preprocessor@5.9.0
npm ERR!     node_modules/@cypress/webpack-preprocessor
npm ERR!       dev @cypress/webpack-preprocessor@"*" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^4.18.1" from @cypress/webpack-preprocessor@5.9.0
npm ERR! node_modules/@cypress/webpack-preprocessor
npm ERR!   dev @cypress/webpack-preprocessor@"*" from the root project
@jennifer-shehane jennifer-shehane added npm: @cypress/webpack-preprocessor @cypress/webpack-preprocessor package issues type: unexpected behavior User expected result, but got another labels Jun 16, 2021
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Jun 21, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 22, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 22, 2021

The code for this is done in cypress-io/cypress#15611, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@chrisbreiding
Copy link
Contributor

Released in 7.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.6.0, please open a new issue.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
npm: @cypress/webpack-preprocessor @cypress/webpack-preprocessor package issues type: unexpected behavior User expected result, but got another
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants