feat: cy.intercept provides req.query. #16916
Merged
+299
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Flaky failures. |
sainthkh
requested review from
flotwig and
chrisbreiding
and removed request for
a team
flotwig
suggested changes
Jun 15, 2021
packages/driver/cypress/integration/commands/net_stubbing_spec.ts
Outdated
Show resolved
Hide resolved
flotwig
approved these changes
Jun 16, 2021
flotwig
suggested changes
Jun 16, 2021
flotwig
reviewed
Jun 16, 2021
flotwig
reviewed
Jun 16, 2021
flotwig
reviewed
Jun 16, 2021
Comment on lines
+1704
to
+1747
| cy.window().then((win) => { | ||
| const xhr = new win.XMLHttpRequest() | ||
|
|
||
| xhr.open('GET', '/users?someKey=someValue') | ||
| xhr.send() | ||
| }) |
There was a problem hiding this comment.
there is no need to do this btw, $.get is available in this context and doesn't require scoping into cy.window().then()
There was a problem hiding this comment.
$.get appends its own query member like _=12345 behind the scene. Because of that, we cannot use them for our tests.
There was a problem hiding this comment.
You can pass cache: true to not do that
There was a problem hiding this comment.
It doesn't work with Firefox. I rolled it back.
flotwig
reviewed
Jun 21, 2021
|
Adding @mccataldo to review from a DX perspective |
flotwig
approved these changes
Jun 22, 2021
mccataldo
approved these changes
Jun 22, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
The incoming request object yielded to request handler functions passed to
cy.intercept()(req) now has areq.queryproperty, which is a getter/setter for the query parameters on the request URL.Additional details
query,urlgetter and setter toreqobject.How has the user experience changed?
Before:
req.query=>undefined.After:
req.query=>{ a: 'b' }PR Tasks
cypress-documentation? => feat: cy.intercept provides req.query. cypress-documentation#3986type definitions?