Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(studio): add ability to copy commands to clipboard #16912

Merged
merged 17 commits into from Jun 25, 2021

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented Jun 13, 2021

User facing changelog

Adds the ability to copy commands generated with Studio to clipboard

Additional details

Addresses some issues from #14767, allowing users to copy to clipboard when saving to file fails. Another PR should be coming soon that more directly prevents that error from happening in the first place.

How has the user experience changed?

ezgif-1-0c376064c269

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 13, 2021

Thanks for taking the time to open a PR!

@panzarino panzarino changed the title feat(studio): add ability to copy commands to clipboard 9a19d1a feat(studio): add ability to copy commands to clipboard Jun 13, 2021
@panzarino panzarino self-assigned this Jun 13, 2021
@cypress
Copy link

cypress bot commented Jun 13, 2021



Test summary

467 0 6 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 9db7c7b
Started Jun 25, 2021 3:05 PM
Ended Jun 25, 2021 3:15 PM
Duration 09:45 💡
OS Linux Debian - 10.8
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@panzarino panzarino marked this pull request as ready for review June 23, 2021 22:02
@panzarino panzarino requested a review from a team as a code owner June 23, 2021 22:02
@panzarino panzarino requested review from jennifer-shehane, kuceb and chrisbreiding and removed request for a team and kuceb June 23, 2021 22:02
lmiller1990
lmiller1990 previously approved these changes Jun 24, 2021
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled it down and gave it a test - works for me.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also tested in Windows and insecure windows.

packages/reporter/src/test/test.tsx Outdated Show resolved Hide resolved
packages/runner-shared/src/event-manager.js Outdated Show resolved Hide resolved
packages/runner-shared/src/studio/studio.jsx Outdated Show resolved Hide resolved
@panzarino
Copy link
Contributor Author

@chrisbreiding Thanks for pointing that out - should be better now

@jennifer-shehane jennifer-shehane merged commit d866a76 into develop Jun 25, 2021
tgriesser added a commit that referenced this pull request Jun 30, 2021
* develop:
  fix: prevent saved state errors for deprecated keys (#17093)
  fix(studio): restore intro modal styles (#17118)
  refactor: add @packages/resolve-dist to isolate client/server code (#17109)
  fix: plugin file referenced by cypress config in angular schematics (#17143)
  refactor: @packages/runner-shared should also be devDependencies (#17133)
  chore: release @cypress/schematic-v1.4.1
  fix: plugin file in angular schematics (#17141)
  chore(runner): render spec list inline (behind feature flag) (#17069)
  refactor: remove junk test (#17125)
  chore(server): collapse project-ct and project-e2e into project-base (#17115)
  fix: make dev-server error message appear only once when CT is not configured (#17090)
  chore: release @cypress/schematic-v1.4.0
  feat: add ng generate to @cypress/schematic to generate e2e spec files (#16962)
  feat(studio): add ability to copy commands to clipboard (#16912)
  chore: release @cypress/webpack-preprocessor-v5.9.1
  chore: release @cypress/webpack-batteries-included-preprocessor-v2.2.2
  chore: release @cypress/vue-v3.0.0-beta.3
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2021

Released in 7.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants