Skip to content

fix: prevent stubbed cy.intercepts from reaching server #15942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Apr 12, 2021

User facing changelog

Fixed an issue introduced in 7.0.0 where requests with responses stubbed via cy.intercept(routeMatcher, staticResponse) would still be sent to the destination server.

Additional details

Introduced in #15255

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

Sorry, something went wrong.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

Thanks for taking the time to open a PR!

@flotwig flotwig marked this pull request as ready for review April 12, 2021 17:06
@flotwig flotwig requested a review from a team as a code owner April 12, 2021 17:06
@flotwig flotwig requested review from chrisbreiding and removed request for a team April 12, 2021 17:06
@cypress
Copy link

cypress bot commented Apr 12, 2021



Test summary

4021 0 49 2Flakiness 0


Run details

Project cypress
Status Passed
Commit ec239db
Started Apr 12, 2021 5:09 PM
Ended Apr 12, 2021 5:19 PM
Duration 10:49 💡
OS Linux Debian - 10.8
Browser Chrome 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[7.0.0] cy.intercept(): stubbed responses still send request to server
2 participants