Skip to content

docs(component-testing): Added rerender/updating props recipe #15742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2021

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Apr 1, 2021

User facing changelog

Provided recipe example of how to update props without remounting in component testing.

How has the user experience changed?

Documentation update only; no user experience changes.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 1, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 1, 2021



Test summary

9394 0 119 3Flakiness 1


Run details

Project cypress
Status Passed
Commit d9b05f6
Started Apr 5, 2021 3:47 AM
Ended Apr 5, 2021 4:00 AM
Duration 12:35 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new recipe is very useful as is.
Could you add a mention of rerender somewhere please?
This is what users are going to be searching for.
Let's give them a leg up ;)

@agg23 agg23 requested a review from elevatebart April 2, 2021 20:12
agg23 and others added 3 commits April 2, 2021 13:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@lmiller1990 lmiller1990 self-requested a review April 5, 2021 03:37
@lmiller1990
Copy link
Contributor

Need approval from @elevatebart to merge.

Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope to get the rerender function in there soon... people will ask for it.

@agg23 agg23 merged commit ddda686 into develop Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants