Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ramda to 0.27.1 #14958

Merged
merged 1 commit into from Feb 18, 2021
Merged

chore: update ramda to 0.27.1 #14958

merged 1 commit into from Feb 18, 2021

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Feb 6, 2021

User facing changelog

N/A

Additional details

Everyone who installs cypress gets an old version of ramda installed, resuling in multiple versions of the same package being installed

How has the user experience changed?

It hasn't

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 6, 2021

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2021

CLA assistant check
All committers have signed the CLA.

@k-yle k-yle changed the title update ramda to 0.27.1 chore: update ramda to 0.27.1 Feb 6, 2021
@k-yle k-yle dismissed a stale review via 2fc8e69 February 7, 2021 03:55
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-yle ramda 0.27.0 is a breaking change release, so you'll need to update all of our ramda code with the breaking changes: ramda/ramda#2978

@k-yle
Copy link
Contributor Author

k-yle commented Feb 8, 2021

hi @jennifer-shehane, there's only one breaking change which affects cypress which is the removal of R.memoize. I've already made this change

@jennifer-shehane
Copy link
Member

Having some issues with our build, let's see if the tests pass.

@jennifer-shehane
Copy link
Member

@k-yle I think the build may be failing due to this change. Can you investigate.

@k-yle
Copy link
Contributor Author

k-yle commented Feb 9, 2021

@jennifer-shehane I suspect the failing firefox integration tests are not my fault since they're failing on develop too?

@jennifer-shehane
Copy link
Member

@k-yle Yah, they're likely just flaky :(

@jennifer-shehane jennifer-shehane merged commit 311cd4b into cypress-io:develop Feb 18, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 1, 2021

Released in 6.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants