Skip to content

fix: open active spec in ide from desktop gui #14521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 19, 2021

Conversation

panzarino
Copy link
Contributor

User facing changelog

Allows users to open the active spec in their IDE

Additional details

Enables opening the active spec in ide from the desktop gui (also changes the cursor when the active spec is hovered)

I've been annoyed with this forever and I've heard some other people mention it to so I figured I'd knock it out

How has the user experience changed?

Before:

ezgif-3-7afcd3061bb2

After:

Note: the hover looks very grey in this gif since its overly saturated, however since the hover styles use opacity its really more of a subtle green grey which looks better when actually running

ezgif-3-d5dd0d520209

Verified

This commit was signed with the committer’s verified signature. The key has expired.
panzarino Zach Panzarino
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 13, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jan 13, 2021



Test summary

9264 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit b23d979
Started Jan 19, 2021 3:54 PM
Ended Jan 19, 2021 4:07 PM
Duration 12:56 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need cy.hover() to test this. 😅 @panzarino I think we can use this plugin to test this though https://github.com/dmtrKovalenko/cypress-real-events If you're interested in trying it out.

The feature works otherwise.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
panzarino Zach Panzarino

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah, it looks like percy snapshots don’t play well with the realHover plugin. You win some, you lose some. 😕

Verified

This commit was signed with the committer’s verified signature. The key has expired.
panzarino Zach Panzarino

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@panzarino
Copy link
Contributor Author

@jennifer-shehane Added a invoke('show') after the hover & assertions to fix the percy snapshots without changing the test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@panzarino panzarino merged commit da6ee21 into develop Jan 19, 2021
pashidlos pushed a commit to pashidlos/cypress that referenced this pull request Jan 30, 2021
@emilyrohrbough emilyrohrbough deleted the open-active-spec-desktop-gui branch August 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants