Skip to content

fix: Cypress.dom.isJquery() returns only boolean results #14325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

sainthkh
Copy link
Contributor

User facing changelog

isJquery returns only boolean results.

Additional details

  • Why was this change necessary? => isJquery sometimes returned undefined.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => Simply added !!.

How has the user experience changed?

Users will not get undefined results.

PR Tasks

  • Have tests been added/updated?

Sorry, something went wrong.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 28, 2020

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review December 28, 2020 07:36
@jennifer-shehane jennifer-shehane self-requested a review December 29, 2020 02:55
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This fixes the original issue.

@jennifer-shehane jennifer-shehane merged commit 6bc3527 into cypress-io:develop Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress.dom.isJquery is inconsistent in return
2 participants