Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Firefox browser #1096

Closed
11 tasks done
brian-mann opened this issue Dec 19, 2017 · 41 comments
Closed
11 tasks done

Support Firefox browser #1096

brian-mann opened this issue Dec 19, 2017 · 41 comments
Assignees
Labels
browser: firefox pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory pkg/driver This is due to an issue in the packages/driver directory pkg/extension This is due to an issue in the packages/extension directory pkg/launcher This is due to an issue in the packages/launcher directory topic: cross browser type: feature New feature that does not currently exist

Comments

@brian-mann
Copy link
Member

brian-mann commented Dec 19, 2017

PR: #1359

  • Update packages/launcher to find Firefox, Firefox Dev Edition, and Firefox Nightly
  • Launch Firefox with profile + args (look at FirefoxDriver for reference)
  • Convert packages/extension to packages/webextension via mozilla polyfill
  • Add server/lib/browsers/firefox.coffee to implement opening the browser
  • Ensure all driver integration tests pass on firefox
  • Ensure all e2e tests pass on firefox
  • Ensure all CSS / visuals work as intended
  • Update our docker images to include firefox Make image with Firefox browser cypress-docker-images#27
  • Make decisions on running e2e or integration tests on firefox in CI
  • Add browser-related property and methods to Cypress
  • Merge in before:browser:launch changes deprecated before:browser:launch event #6293
@jennifer-shehane jennifer-shehane added browser: firefox external: docker pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory pkg/driver This is due to an issue in the packages/driver directory pkg/extension This is due to an issue in the packages/extension directory pkg/launcher This is due to an issue in the packages/launcher directory type: feature New feature that does not currently exist labels Dec 19, 2017
@jennifer-shehane jennifer-shehane changed the title Support Firefox browser Support 🦊 Firefox browser Dec 19, 2017
@jennifer-shehane jennifer-shehane changed the title Support 🦊 Firefox browser Support Firefox browser Dec 19, 2017
@brian-mann
Copy link
Member Author

First passing testing running Cypress in Firefox...

screen shot 2018-01-09 at 11 13 11 pm

@Velveeta
Copy link

I and my organization cannot express our ❤️s for you enough right now... I shall drink to your success today... and I shall drink right now........ and also 4 hours ago...

@aaronherman
Copy link

Is there any update on this?

@brian-mann
Copy link
Member Author

The branch is here: https://github.com/cypress-io/cypress/tree/issue-1096-firefox-support

Chris had to pivot and help with another project but he's actually back to work on Firefox support this week. It'll land whenever all the tests pass. There are some failing tests which are causing us to have to update portions of the driver - some of which take a lot of research to reproduce and understand why they're failing. It's nearly there but a bit more to go...

@morficus
Copy link

Just a heads up... your Docker image includes instructions on how to run Cypress using Firefox, but there is no Firefox support yet. It may be advisable to either link to this issue in Docker Hub or put something in the Docker Hub repo info about Firefox being installed but not usable yet.

https://hub.docker.com/r/cypress/browsers/

@ikornienko
Copy link

It seemed to be so close, a lot of commits flying into the corresponding branch, and then it seems like some higher priority stuff came up, no activity since the end of Feb... @brian-mann can you please share an update on it? Is there a timeline change for adding this support or is it postponed indefinitely because of some hard to resolve problem?

@jennifer-shehane
Copy link
Member

Indeed, we have deemed some other work as higher priority. We are mainly working on releasing this Epic which will pave the way for parallelizing specs.

We're sorry for the delay on Firefox support - it is still on our Roadmap and the work that has been committed is still of value to our project.

@serhiibr
Copy link

@jennifer-shehane , thanks for update. Is there an approximate date when the first test in Firefox browser can be runned?

@Alon87
Copy link

Alon87 commented May 24, 2018

Any updates or a current build we can use to run a working Firefox automation in cypress.io?

@pgroot91
Copy link

pgroot91 commented May 24, 2018

@Alon87 My guess is they are trying to push hard to finally finish/push out version 3.0 before they are start focusing and finishing on the rest. Alse red somewhere that they are aiming for a 2 week release cycle after v3. It looks like everything is standing still since the last update was probably 2 months ago. Also can't wait to see support for FF.

@willischu
Copy link

bump

@Mathyn
Copy link

Mathyn commented Jul 1, 2019

Any updates on this?

@mgol
Copy link

mgol commented Jul 1, 2019

Right, there haven't been any new commits on the issue-1096-firefox-support branch since October. It'd be good to hear about progress updates from time to time.

My company may be evaluating a new e2e solution soon and having some knowledge about Firefox support progress would help.

@metasean
Copy link

metasean commented Jul 2, 2019

It looks like the latest info is available on issue #3207 - Cross Browser issue tracker.

Unfortunately, other than the almost completely unchecked todo list at the top, there doesn't appear to be any meaningful movement on the Firefox front 😟

@digitarald
Copy link

In case people are watching this issue, active development is happening in #1359

@mayrbenjamin92
Copy link

We would love to have FF support <3!

@L0wry
Copy link

L0wry commented Nov 28, 2019

Hey pals,
So so so keen to get this over the line. Anything I can do to help?

@kuntemandar
Copy link

Hello Pals,

has anyone tried the pre-release version for firefox like here:
#1359 (comment)

i am trying to understand what the steps in https://on.cypress.io/installing-cypress#Install-pre-release-version are for? is it for users to try out the features in the unmerged develop branch. If so i has anyone tried it. I installed the binary but not able to see firefox in the list of browsers when i do npx cypress open

@ludakhris
Copy link

@kuntemandar suspect you might be a bit early lol. They haven’t released the binaries yet, their just working the documentation for it’s eventual release.

@kuntemandar
Copy link

@kuntemandar suspect you might be a bit early lol. They haven’t released the binaries yet, their just working the documentation for it’s eventual release.

Got it, thanks for clarifying, saved sometime for me... 😄

@jennifer-shehane
Copy link
Member

We are still actively working on releasing Firefox support. Currently the release is blocked by a garbage collection issue that causes Firefox to crash during some tests during cypress run. We're working with the Firefox team and also trying several creative workarounds to prevent the crashing.

@Baastieng
Copy link

Thank you so much for your hard work. That's been a while I'm waiting for this Firefox compatibility :) Can't wait to use it 💪

@uptownhr
Copy link

Does the release of playwright mean any possibilities here for faster browser support?

@tikolakin
Copy link

Additionally, release of firefox support in puppeter, does it help with getting cypress firefox support released?
https://twitter.com/mathias/status/1222183802870607872

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 6, 2020

The code for this is done in cypress-io/cypress#1359, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Feb 6, 2020
@Velveeta
Copy link

Velveeta commented Feb 6, 2020

I certainly hope so, because you all started off as a hot contender, but are falling behind the market to Puppeteer and Playwright at this point...

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 6, 2020

Released in 4.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: firefox pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory pkg/driver This is due to an issue in the packages/driver directory pkg/extension This is due to an issue in the packages/extension directory pkg/launcher This is due to an issue in the packages/launcher directory topic: cross browser type: feature New feature that does not currently exist
Projects
None yet
Development

No branches or pull requests