From bd64fe6e288644c20ff7956df6301b95fec62622 Mon Sep 17 00:00:00 2001 From: Zach Bloomquist Date: Mon, 5 Dec 2022 23:32:15 -0500 Subject: [PATCH] update comments --- packages/driver/cypress/e2e/commands/navigation.cy.js | 4 ++-- packages/driver/cypress/e2e/cypress/proxy-logging.cy.ts | 2 +- packages/driver/cypress/e2e/e2e/focus_blur.cy.js | 2 +- packages/driver/cypress/e2e/e2e/react-15.cy.js | 2 +- packages/driver/cypress/e2e/e2e/react-16.cy.js | 2 +- packages/driver/cypress/e2e/e2e/text_mask.cy.js | 2 +- packages/driver/cypress/e2e/issues/1244.cy.js | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/driver/cypress/e2e/commands/navigation.cy.js b/packages/driver/cypress/e2e/commands/navigation.cy.js index 8379e0ccf1b7..9bb7b3580791 100644 --- a/packages/driver/cypress/e2e/commands/navigation.cy.js +++ b/packages/driver/cypress/e2e/commands/navigation.cy.js @@ -1803,7 +1803,7 @@ describe('src/cy/commands/navigation', () => { }) }) - // TODO(webkit): fix+unskip for experimental webkit release + // TODO(webkit): fix+unskip for webkit release context('#page load', { browser: '!webkit' }, () => { it('sets initial=true and then removes', () => { Cookie.remove('__cypress.initial') @@ -2200,7 +2200,7 @@ describe('src/cy/commands/navigation', () => { }) }) - // TODO(webkit): fix+unskip for experimental webkit release + // TODO(webkit): fix+unskip for webkit release context('#url:changed', { browser: '!webkit' }, () => { beforeEach(function () { this.logs = [] diff --git a/packages/driver/cypress/e2e/cypress/proxy-logging.cy.ts b/packages/driver/cypress/e2e/cypress/proxy-logging.cy.ts index cf826c50f18e..29878eab0ad9 100644 --- a/packages/driver/cypress/e2e/cypress/proxy-logging.cy.ts +++ b/packages/driver/cypress/e2e/cypress/proxy-logging.cy.ts @@ -49,7 +49,7 @@ describe('Proxy Logging', () => { it('fetch log shows resource type, url, method, and status code and has expected snapshots and consoleProps', { // TODO: fix flaky test https://github.com/cypress-io/cypress/issues/23443 retries: 15, - // TODO(webkit): fix+unskip for experimental webkit release + // TODO(webkit): fix+unskip for webkit release browser: '!webkit', }, (done) => { fetch('/some-url') diff --git a/packages/driver/cypress/e2e/e2e/focus_blur.cy.js b/packages/driver/cypress/e2e/e2e/focus_blur.cy.js index e80a5c1de06c..8a4f552d44bb 100644 --- a/packages/driver/cypress/e2e/e2e/focus_blur.cy.js +++ b/packages/driver/cypress/e2e/e2e/focus_blur.cy.js @@ -509,7 +509,7 @@ describe('polyfill programmatic blur events', () => { }) }) -// TODO(webkit): fix+unskip for experimental webkit release +// TODO(webkit): fix+unskip for webkit release describe('intercept blur methods correctly', { browser: '!webkit' }, () => { beforeEach(() => { cy.visit('http://localhost:3500/fixtures/active-elements.html').then(() => { diff --git a/packages/driver/cypress/e2e/e2e/react-15.cy.js b/packages/driver/cypress/e2e/e2e/react-15.cy.js index 16c8561e1468..504e81914c89 100644 --- a/packages/driver/cypress/e2e/e2e/react-15.cy.js +++ b/packages/driver/cypress/e2e/e2e/react-15.cy.js @@ -1,4 +1,4 @@ -// TODO(webkit): fix+unskip for experimental webkit release +// TODO(webkit): fix+unskip for webkit release describe('react v15.6.0', { browser: '!webkit' }, () => { context('fires onChange events', () => { beforeEach(() => { diff --git a/packages/driver/cypress/e2e/e2e/react-16.cy.js b/packages/driver/cypress/e2e/e2e/react-16.cy.js index 7a7c989ad256..9a81d3f8c4d4 100644 --- a/packages/driver/cypress/e2e/e2e/react-16.cy.js +++ b/packages/driver/cypress/e2e/e2e/react-16.cy.js @@ -1,4 +1,4 @@ -// TODO(webkit): fix+unskip for experimental webkit release +// TODO(webkit): fix+unskip for webkit release describe('react v16.0.0', { browser: '!webkit' }, () => { context('fires onChange events', () => { beforeEach(() => { diff --git a/packages/driver/cypress/e2e/e2e/text_mask.cy.js b/packages/driver/cypress/e2e/e2e/text_mask.cy.js index 18a4580a96a6..13a22bfcc322 100644 --- a/packages/driver/cypress/e2e/e2e/text_mask.cy.js +++ b/packages/driver/cypress/e2e/e2e/text_mask.cy.js @@ -1,6 +1,6 @@ let changed = 0 -// TODO(webkit): fix+unskip for experimental webkit release +// TODO(webkit): fix+unskip for webkit release describe('src/cy/commands/actions/type text_mask_spec', { browser: '!webkit' }, () => { beforeEach(() => { cy.visit('/fixtures/text-mask.html') diff --git a/packages/driver/cypress/e2e/issues/1244.cy.js b/packages/driver/cypress/e2e/issues/1244.cy.js index ea208886c68a..a1c2fd78d577 100644 --- a/packages/driver/cypress/e2e/issues/1244.cy.js +++ b/packages/driver/cypress/e2e/issues/1244.cy.js @@ -11,7 +11,7 @@ describe('issue 1244', () => { for (const [el, target, action] of [['button', 'form', 'submit'], ['a', 'a', 'click']]) { //
submit, click - // TODO(webkit): fix+unskip for experimental webkit release, or make skip more specific (only 4 of these generated tests fail in webkit) + // TODO(webkit): fix+unskip for webkit release, or make skip more specific (only 4 of these generated tests fail in webkit) describe(`<${target}> ${action}`, { browser: '!webkit' }, () => { it('correctly redirects when target=_top with target.target =', () => { cy.get(`${el}.setTarget`).click()