From 2fd495ca1caf3754bc77ea5af5e0e3a7ee057697 Mon Sep 17 00:00:00 2001 From: Zachary Williams Date: Fri, 29 Jul 2022 14:03:43 -0500 Subject: [PATCH] refactor: use cp.fork to preserve stdout for packages/extension build (#22926) --- packages/extension/gulpfile.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/extension/gulpfile.ts b/packages/extension/gulpfile.ts index b171ba308361..c03c0b6deb92 100644 --- a/packages/extension/gulpfile.ts +++ b/packages/extension/gulpfile.ts @@ -2,8 +2,9 @@ import gulp from 'gulp' import rimraf from 'rimraf' import * as cypressIcons from '@packages/icons' import cp from 'child_process' -import util from 'util' -const exec = util.promisify(cp.exec) +import * as path from 'path' + +const nodeWebpack = path.join(__dirname, '..', '..', 'scripts', 'run-webpack.js') const clean = (done) => { rimraf('dist', done) @@ -15,7 +16,9 @@ const manifest = () => { } const background = (cb) => { - exec('node ../../scripts/run-webpack.js').then(() => cb()).catch(cb) + cp.fork(nodeWebpack, { stdio: 'inherit' }).on('exit', (code) => { + cb(code === 0 ? null : new Error(`Webpack process exited with code ${code}`)) + }) } const html = () => {