Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overriding env variables wording to be clearer #236

Closed
jennifer-shehane opened this issue Nov 16, 2017 · 2 comments
Closed

Update overriding env variables wording to be clearer #236

jennifer-shehane opened this issue Nov 16, 2017 · 2 comments

Comments

@jennifer-shehane
Copy link
Member

Values in here will overwrite conflicting values in cypress.json.

From discussion on cypress-io/cypress#909, this should really say:

Values in here will overwrite conflicting environment variables in cypress.json.

@clairecliu
Copy link
Contributor

I would like to give this a try.

@danverde
Copy link

danverde commented Apr 2, 2019

The docs currently say:

You can also use environment variables to override configuration values. This is especially useful in Continuous Integration or when working locally. This gives you the ability to change configuration options without modifying any code or build scripts.

By default, any environment variable that matches a corresponding configuration key will override the cypress.json value.

and

Environment variables that do not match configuration keys will instead be set as regular environment variables

From what I understood of cypress-io/cypress#909 environment variables cannot override configuration values and the docs should be updated accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants