Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: migrate to new interface for starting async things #583

Open
oliver-sanders opened this issue Apr 10, 2024 · 0 comments
Open

server: migrate to new interface for starting async things #583

oliver-sanders opened this issue Apr 10, 2024 · 0 comments
Labels
Milestone

Comments

@oliver-sanders
Copy link
Member

We need to run some async stuff when we start the server. Currently we are hacking this into initialize_settings:

ioloop.IOLoop.current().add_callback(
self.workflows_mgr.run
)
# configure the scan interval
ioloop.PeriodicCallback(
self.workflows_mgr.scan,
self.scan_interval * 1000
).start()

Jupyter Server may acquire a less hacky interface for this in the future: jupyter-server/jupyter_server#1329

We should migrate to this in due course. Remember to bump the jupyter_server dependency when doing this.

@oliver-sanders oliver-sanders added this to the pending milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant