Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI coverage for PR's #328

Closed
kinow opened this issue Dec 10, 2019 · 1 comment
Closed

Fix CI coverage for PR's #328

kinow opened this issue Dec 10, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kinow
Copy link
Member

kinow commented Dec 10, 2019

Describe the bug

Coverage is now almost working after #324 , but unfortunately looks like the secret token is not available for PR's when the branch is in another repository.

Release version(s) and/or repository branch(es) affected?

Steps to reproduce the bug

Submit a PR from a branch in your fork. Check the GitHub action console output for the step to upload coverage report.

Expected behavior

Screenshots

Additional context

See: codecov/codecov-action#29

Maybe related to codecov/codecov-node#160, if we decided to ditch their github-action and just use the codecov node utility.

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@kinow kinow added the bug Something isn't working label Dec 10, 2019
@kinow kinow added this to the 0.2 milestone Dec 10, 2019
@kinow kinow modified the milestones: 0.2, 0.3 Jan 6, 2020
@kinow
Copy link
Member Author

kinow commented Mar 10, 2020

The issue in the Codecov GitHub action was fixed & released 4 days ago. My most recent PR to Cylc UI was from 8 days ago, which failed to upload coverage:

image

So closed, then re-opened that PR, and it just successfully uploaded the coverage report 🎉

image

Closing!

@kinow kinow closed this as completed Mar 10, 2020
@kinow kinow modified the milestones: 0.3, 0.2 Mar 10, 2020
@kinow kinow self-assigned this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant