Get rid of --dump parameter?

[lupinitylabs]

I don't see the need for both the --file and --dump parameters - they are essentially doing the same.

Since the --file parameter expects an absolute path, the --dump (or --file) parameter could be removed and all files without paths could safely be assumed to be in the database folder.

Another benefit besides shortening the parameter list would be that it removes some of the logic and allows for the use of a match statement at

laravel-protector/src/Commands/ImportDump.php

Line 91 in e4e001f

if ($optionRemote) {

.

Furthermore, I find the double use of $localFilePath at

laravel-protector/src/Commands/ImportDump.php

Line 105 in e4e001f

$localFilePath = $this->protector->createTempFilePath($importFilePath);

confusing, which could be either a temporary file copy of an imported dump or an existing dump file in the database dump folder, which requires an additional check at

laravel-protector/src/Commands/ImportDump.php

Line 110 in e4e001f

if (!$optionFile) {

to see if it can be deleted.

I feel like all the logic in the handle() method could be refactored and maybe included in importDump(), or having additional methods like importDumpFromTempFile(), importLatestDump() or importDumpFromRemote(), to make the code more readable and move the logic.