Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that JsonMapper is not designed for input validation #238

Open
dktapps opened this issue May 13, 2024 · 0 comments
Open

Document that JsonMapper is not designed for input validation #238

dktapps opened this issue May 13, 2024 · 0 comments

Comments

@dktapps
Copy link
Contributor

dktapps commented May 13, 2024

If JsonMapper can't be relied on for JSON validation during mapping, it should be clearly documented so that no one tries to rely on the library for data validation. All of the security issues coming from PocketMine-MP arose because of validation loopholes in JsonMapper that I didn't expect.

FWIW, other libraries like Valinor do perform full validation, so I don't think it's unreasonable to assume that complete validation would be a part of a library like this.

Related to: #226 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant