Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more global focus handling #1210

Open
michaeljaltamirano opened this issue Oct 11, 2021 · 0 comments
Open

Add more global focus handling #1210

michaeljaltamirano opened this issue Oct 11, 2021 · 0 comments

Comments

@michaeljaltamirano
Copy link
Contributor

michaeljaltamirano commented Oct 11, 2021

We have 7 instances of the following general style pattern in this repo:

// incomplete to cover both theme.BOX_SHADOWS.focus and theme.BOX_SHADOWS.focusInner
&:focus {
    outline: none;
    box-shadow: ${({ theme }) => theme.BOX_SHADOWS

This pattern is also starting to proliferate in consumer apps, especially as we overwrite blue browser focus outlines in favor of our own style. We should consider adding this to our global stylesheets for common control components (e.g. button)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant