The shadowroot attribute gets special treatment, but the new shadowrootmode attribute should too

[mfreed7]

See the code:

https://github.com/cure53/DOMPurify/blob/main/src/purify.js#L1465

The shadowroot attribute, which triggers "old-style" declarative shadow DOM, gets special treatment. See this issue for context: #584

Recently, the declarative Shadow DOM feature has had renewed interest, and as part of that conversation, the shadowroot attribute was renamed to shadowrootmode. Chrome has shipped this new attribute in M111. Chrome also will continue supporting the old shadowroot attribute for some time, as developers migrate.

I believe DOMPurify should be updated to look for both shadowroot and shadowrootmode.

@securityMB

[cure53]

Aye, thanks - that proposal looks good to me and and worth a change.

So, the changed syntax should be this? if (ALLOWED_ATTR.shadowroot || ALLOWED_ATTR.shadowrootmode) { ?

[mfreed7]

Aye, thanks - that proposal looks good to me and and worth a change.

So, the changed syntax should be this? if (ALLOWED_ATTR.shadowroot || ALLOWED_ATTR.shadowrootmode) { ?

Looks right to me!

[cure53]

Cool, thanks - will add :)

[cure53]

This should be fixed now!