Support sanitization of attributes that require Trusted Types #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thank you! |
|
Do you need a release for this? |
|
Yes please but we can wait a week or two if needed. |
|
Which is exactly when I will be on vacation 😬 That is why I am asking 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR should fix 660 for attributes without namespace.
Background & Context
We want to use DOMPurify to allow
script.srcattribute and provide custom src validation via hooks. This is not possible today as DOMPurify will call setAttribute with raw string and cause Trusted Types Sink violation.This PR leverages TrustedTypePolicyFactory.getAttributeType() to handle such cases.