Make TAG and ATTR cfg options case-sensitive when parsing XHTML #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thank you! |
cure53
added a commit
that referenced
this pull request
Jun 6, 2022
cure53
added a commit
that referenced
this pull request
Jun 6, 2022
|
@cure53 , do you have a release date for this change? Thanks. |
|
Why not now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A while back we introduced PARSER_MEDIA_TYPE option for parsing XHTML files where tag and attribute names are case-sensitive.
We have one use case where we would like DOMPurify to keep certain custom tags and attributes by specifying ALLOWED_TAGS and ALLOWED_ATTR options. The problem is that
addToSetfunction forces lowercase by callingstringToLowerCaseon all elements. DOMPurify therefore does not respect ALLOWED_TAGS and ALLOWED_ATTR options and always removes our custom tags and attributes.This PR fixes this issue by passing
transformCaseFunctoaddToSet, happy to redo if there is a better way to do it.