Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix import path for testing #632

Merged
merged 1 commit into from Jan 25, 2022
Merged

chore: fix import path for testing #632

merged 1 commit into from Jan 25, 2022

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Jan 25, 2022 •
edited

This PR fixes importing path for purify

Background & Context

I found this PR changed both purify.spec.js and purify.min.spec.js to import purify.min.

But purify.spec.js should test purify, not purify.min.

tdeekens
tdeekens approved these changes Jan 25, 2022
View reviewed changes
Copy link
Collaborator

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Makes sense. Maybe somebody else should review too.

@cure53 cure53 merged commit 10d6dfc into cure53:main Jan 25, 2022
@is2ei is2ei deleted the fix-import-path branch January 25, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@is2ei @tdeekens @cure53