Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file.Glob: Replace stdlib Glob to support double star syntax #1919

Open
fionera opened this issue Sep 9, 2022 · 3 comments · May be fixed by #1920
Open

file.Glob: Replace stdlib Glob to support double star syntax #1919

fionera opened this issue Sep 9, 2022 · 3 comments · May be fixed by #1920
Labels
FeatureRequest New feature or request

Comments

@fionera
Copy link

fionera commented Sep 9, 2022 •
edited

Is your feature request related to a problem? Please describe.
The Go stdlib implements Glob with Match as its base and does not support the double star syntax. To allow recursive lists via file.Glob it should be supported.

Describe the solution you'd like
Replace the usage of the stdlib Glob with an implementation that supports double stars like https://github.com/bmatcuk/doublestar

Describe alternatives you've considered
I didnt found any good way to list all files of an extension recursively

Additional context
https://stackoverflow.com/questions/26809484/how-to-use-double-star-glob-in-go
golang/go#11862
@fionera fionera added the Triage Requires triage/attention label Sep 9, 2022
@myitcv myitcv added FeatureRequest New feature or request and removed Triage Requires triage/attention labels Sep 10, 2022
@myitcv
Copy link
Member

myitcv commented Sep 10, 2022

Thanks for raising. Please can you edit the description above, filling out the template for a feature request:

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.

The "Feature Request" issue type is linked from https://github.com/cue-lang/cue/issues/new/choose for convenience.

@fionera
Copy link
Author

fionera commented Sep 10, 2022

Sure thing :) I wasnt sure if this is a feature request or a bug since CUE already has a Glob feature, but doesnt implement the full spec.

@fionera fionera linked a pull request Sep 10, 2022 that will close this issue
Open
@myitcv
Copy link
Member

myitcv commented Sep 14, 2022

but doesnt implement the full spec.

The history behind that decision is covered in golang/go#11862. I think we need to first reach agreement that we want to implement/use something different for CUE. And then discuss how that should be implemented.

@myitcv myitcv added the zGarden label Jun 13, 2023
@mvdan mvdan removed the zGarden label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/tool/file: Replace filepath.Glob with doublestar.FilepathGlob fionera/cue
3 participants
@myitcv @mvdan @fionera