Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice to godog CLI #489

Merged
merged 2 commits into from Jul 31, 2022
Merged

Add deprecation notice to godog CLI #489

merged 2 commits into from Jul 31, 2022

Conversation

vearutop
Copy link
Member

@vearutop vearutop commented Jul 24, 2022

🤔 What's changed?

godog, godog build and godog run would issue deprecation warning before proceeding.

Use of godog CLI is deprecated, please use *testing.T instead.
See https://github.com/cucumber/godog/discussions/478 for details.

⚡️ What's your motivation?

A poll in discussions has been active for couple of months already with general consensus in favor of CLI deprecation.
This PR makes the next step to issue a deprecation notice to improve visibility of upcoming change.
There is also chance that deprecation will be canceled if new facts will be present in related discussion.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #489 (c62c7fe) into main (d45a9aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files          27       27           
  Lines        2267     2267           
=======================================
  Hits         1852     1852           
  Misses        316      316           
  Partials       99       99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45a9aa...c62c7fe. Read the comment docs.

@vearutop vearutop merged commit 6f3e792 into main Jul 31, 2022
@vearutop vearutop deleted the deprecate-cli branch July 31, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants