Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version subcommand. Do not print usage if run subcommand fails. #475

Merged
merged 2 commits into from May 20, 2022

Conversation

coopernurse
Copy link
Contributor

@coopernurse coopernurse commented May 10, 2022

🤔 What's changed?

godog version now prints the version number again and godog run will no longer print usage if a test fails.

⚡️ What's your motivation?

  • godog version wasn't printing the version number
  • godog run was printing usage when a test failed, which cluttered up the output, and didn't seem intentional

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Would you like the CHANGELOG updated for this?

📋 Checklist:

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #475 (ee1dbb6) into main (5793a95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          27       27           
  Lines        2197     2197           
=======================================
  Hits         1789     1789           
  Misses        312      312           
  Partials       96       96           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5793a95...ee1dbb6. Read the comment docs.

Copy link
Member

@vearutop vearutop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. 👍

@vearutop vearutop merged commit d52a4d3 into cucumber:main May 20, 2022
@aslakhellesoy
Copy link
Collaborator

Hi @coopernurse,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants