Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'go get' instead of 'go install' to install #449

Merged
merged 2 commits into from Dec 29, 2021

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Dec 20, 2021

Description

PR modifies the README.md to use the modern go install instead of the deprecated go get method to install the binary.

Motivation & context

https://go.dev/doc/go-get-install-deprecation

Type of change

minor documentation change

Note to other contributors

If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.

Update required of cucumber.io/docs

If the Cucumber documentation will require an update,
submit an issue or ideally a pull request to cucumber/docs and
reference it here.

e.g. "Ref: cucumber/docs/pull/#99"

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #449 (e0172b5) into main (b850b44) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          26       26           
  Lines        2175     2175           
=======================================
  Hits         1771     1771           
  Misses        311      311           
  Partials       93       93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b850b44...e0172b5. Read the comment docs.

Copy link
Member

@vearutop vearutop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vearutop
Copy link
Member

@dmitris could you also update CHANGELOG.md?

@dmitris
Copy link
Contributor Author

dmitris commented Dec 29, 2021

@vearutop updated, the CHANGELOG please take a look

btw. the links to both CONTRIBUTING and CHANGELOG are both wrong/dead in the Checklist in the PR template above - I didn't see where the file for that template is located, maybe you could fix it? Thanks.

@vearutop vearutop merged commit 4d9b548 into cucumber:main Dec 29, 2021
@aslakhellesoy
Copy link
Contributor

Hi @dmitris,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@dmitris dmitris deleted the patch-1 branch December 29, 2021 14:31
@mattwynne
Copy link
Member

Thanks @dmitris! We're actively looking for more people to help maintain GoDog, so if you're interested in getting more involved, I'd love to help make that happen.

You're welcome to join us in our community Slack in the #committers channel 😄 or the #commiters-go channel.

I'm also making myself available for live pairing ⚡ you can book a slot with me here if you want to work on something or just chat about how to get involved.

@dmitris
Copy link
Contributor Author

dmitris commented Jan 21, 2022

thanks @aslakhellesoy and @mattwynne, very nice of you to be so welcoming, I will definitely look for opportunities to contribute to GoDog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants