Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "state" pattern in suite.runSteps #446

Open
mattwynne opened this issue Dec 3, 2021 · 0 comments
Open

Use "state" pattern in suite.runSteps #446

mattwynne opened this issue Dec 3, 2021 · 0 comments

Comments

@mattwynne
Copy link
Member

The runStep function has a bunch of conditional logic in it, which I think could be simplified by the application of the State design pattern.

We use this in the Ruby version, and pretty much eliminated every if statement, meaning a whole class of bugs like #434 disappeared.

What do folks think? Could we do something like this? Would it be useful?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattwynne