-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dry run with messages #1540
Conversation
Also fixes #1488
So, it looks like the order of the filters is very important 😅 |
.github/workflows/cucumber-ruby.yml
Outdated
@@ -10,6 +10,9 @@ name: Ruby | |||
on: | |||
push: | |||
branches: [main, publish-option] | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should not do this. We only want to publish reports for what's on the main branch.
I understand why you did this, and I think what we need instead is a unit or acceptance test that reproduces the problem that surfaces here when you run cucumber --publish
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am stuck trying to add an acceptance test which reproduce the issue
This is because the tested code is also the testing code. Because of that we cannot have acceptance tests based on the execution order of the filters in the runtime because it is actually executed a first time before executing the test itself.
At the moment I have not been able yet to write a spec either.
Co-authored-by: Matt Wynne <matt@cucumber.io>
Co-authored-by: Matt Wynne <matt@cucumber.io>
We decided that adding a test for this is too hard right now, as:
|
Fixes #1496 and #1488
I've just applied the suggestion from @cbochs in #1496, it seems to work as expected.
It did not get well previously actually :(