Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated change log ahead of Cucumber-rails v1.6.0 release #385

Conversation

xtrasimplicity
Copy link
Member

@xtrasimplicity xtrasimplicity commented Apr 20, 2018

Summary

I've just updated the changelog with some of the main things I found in the commit logs, between the last release and this one. Please expand as necessary. :)

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This change is Reviewable

@xtrasimplicity xtrasimplicity added this to the 1.6.0 milestone Apr 20, 2018
CHANGELOG.md Outdated
@@ -7,6 +7,10 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO
* Update .travis.yml with ruby versions ([#341](https://github.com/cucumber/cucumber-rails/pull/341) Jun Aruga)
* Removed support for Ruby <= 2.1, to keep in line with [cucumber-ruby](https://github.com/cucumber/cucumber-ruby/blob/master/CHANGELOG.md#302-2017-11-11) ([#360](https://github.com/cucumber/cucumber-rails/pull/360) [xtrasimplicity](https://github.com/xtrasimplicity)).
* Updated syntax to support both new and deprecated forms of tag negation. ([#348](https://github.com/cucumber/cucumber-rails/pull/348) [mirelon](https://github.com/mirelon), [#359](https://github.com/cucumber/cucumber-rails/pull/359) [xtrasimplicity](https://github.com/xtrasimplicity))
* Switched to Ruby 1.9 hash syntax. ([#371](https://github.com/cucumber/cucumber-rails/pull/371) [mvz](https://github.com/mvz))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up in the heading of this section, the compare link is wrong. We use v1.5.0 tags, so that link should be

https://github.com/cucumber/cucumber-rails/compare/v1.5.0...master

(I have not checked the other tags, nor the rest of this document.)

@xtrasimplicity
Copy link
Member Author

@olleolleolle All fixed. :)

Copy link
Contributor

@mvz mvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xtrasimplicity xtrasimplicity merged commit bf0ec80 into cucumber:master Apr 21, 2018
@xtrasimplicity xtrasimplicity deleted the ReleasePreparation/UpdateChangelog branch April 21, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants