Add Rails 5.2 & Capybara 3 support. #378

gobijan · 2018-04-12T04:11:45Z

Summary

Relax the runtime dependencies to allow railties version 5.2.

Details

Relax the runtime dependencies to allow railties version 5.2.

Motivation and Context

Allow Rails 5.2 now that it's released.

How Has This Been Tested?

No introduction of new tests. Relying on tests that are already there.

Screenshots (if appropriate):

none.

Types of changes

Bug fix (non-breaking change which fixes an issue).
New feature (non-breaking change which adds functionality).
Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

I've added tests for my code.
My change requires a change to the documentation.
I have updated the documentation accordingly.

mvz · 2018-04-12T04:50:57Z

Maybe @gobijan and @roberts1000 can cooperate on this 😉.

…ies < 6.

gobijan · 2018-04-12T06:17:05Z

Sure. I am experimenting on my PR and trying latest gem versions. @roberts1000 you have any findings to share for now?

mvz · 2018-04-12T07:04:21Z

cucumber-rails.gemspec

  s.add_development_dependency('builder', ['>= 3.1.0', '< 4'])
  s.add_development_dependency('bundler', '>= 1.3.5')
  s.add_development_dependency('selenium-webdriver', '>= 3.4.1')
  s.add_development_dependency('database_cleaner', '>= 1.0.0')
  s.add_development_dependency('factory_girl', '>= 3.2')
  s.add_development_dependency('rake', '>= 0.9.2.2')
-  s.add_development_dependency('rspec', '~> 3.0')
+  s.add_development_dependency('rspec', '~> 3')


This will allow RSpec 4, which is probably not what you want.

mvz · 2018-04-12T07:05:02Z

cucumber-rails.gemspec

  s.add_runtime_dependency('mime-types', ['>= 1.17', '< 4'])

  # Main development dependencies
  s.add_development_dependency('ammeter', ['>= 1.0.0', '!= 1.1.3'])
  s.add_development_dependency('appraisal', '>= 0.5.1')
-  s.add_development_dependency('aruba', '~> 0.14.2')
+  s.add_development_dependency('aruba', '>= 0.14.2')


The latest release of aruba is in the 0.14.x series, so this change has no effect currently.

xtrasimplicity · 2018-04-14T10:47:10Z

cucumber-rails.gemspec

@@ -12,23 +12,23 @@ Gem::Specification.new do |s|

  s.license = 'MIT'

-  s.add_runtime_dependency('capybara', ['>= 1.1.2', '< 3'])
+  s.add_runtime_dependency('capybara', ['>= 1.1.2', '< 4'])


This also resolves @Kosmas' request here: #375 (comment) 👍

roberts1000 · 2018-04-14T19:02:19Z

@gobijan Glad to see someone else is taking a look at this one! I didn't hit the same test failures that you hit. I tried to avoid changing gem/ruby versions if they weren't related to Rails 5.2 so that may the reason for the difference. My PR is failing on a bootsnap loading error.

radar · 2018-04-17T23:33:29Z

.travis.yml

@@ -1,8 +1,7 @@
 rvm:
-  - 2.2.9


I would suggest keeping this, as cucumber-rails still is using Ruby 2.2. If Rails 5.2 requires higher, then I suggest excluding it below in .travis.yml.

radar · 2018-04-17T23:34:06Z

cucumber-rails.gemspec

  s.add_runtime_dependency('mime-types', ['>= 1.17', '< 4'])

  # Main development dependencies
  s.add_development_dependency('ammeter', ['>= 1.0.0', '!= 1.1.3'])
  s.add_development_dependency('appraisal', '>= 0.5.1')
-  s.add_development_dependency('aruba', '~> 0.14.2')
+  s.add_development_dependency('aruba', '>= 0.14.2')
  s.add_development_dependency('builder', ['>= 3.1.0', '< 4'])
  s.add_development_dependency('bundler', '>= 1.3.5')
  s.add_development_dependency('selenium-webdriver', '>= 3.4.1')
  s.add_development_dependency('database_cleaner', '>= 1.0.0')
  s.add_development_dependency('factory_girl', '>= 3.2')


Consider changing this to factory_bot while you're here too. There will need to be some other changes made to the features (like emulate_javascript.feature too)

I've just submitted a PR to your repo for this: gobijan#2

radar · 2018-04-17T23:44:50Z

Keen to get this merged so that we can upgrade to Rails 5.2 as well. To help with the effort, I'm opening a few PRs on @gobijan's repo too:

gobijan#1
gobijan#2

…ies < 6.

Make click_with_javascript_emulation take any args

gobijan · 2018-04-20T06:20:16Z

I just merged the pull requests in. Let's see :)

xtrasimplicity · 2018-04-20T06:34:27Z

Apart from the `geckodriver -v` issues in a few runs, it is looking pretty good! Great work, everyone!

…

On Fri., 20 Apr. 2018, 16:20 Bijan Rahnema, ***@***.***> wrote: I just merged the pull requests in. Let's see :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#378 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI4pzQ7ae4q-O1BipBIKVPwrCUeAhr9-ks5tqX4igaJpZM4TRHPH> .

xtrasimplicity

I've restarted the erroneous tests and can confirm everything is working. Let's work on the requested changes in the reviews above, then we can get this merged. :)

xtrasimplicity · 2018-04-20T08:15:57Z

cucumber-rails.gemspec

@@ -37,7 +37,7 @@ Gem::Specification.new do |s|
  s.add_development_dependency('rdoc', '>= 3.4')
  s.add_development_dependency('yard', '>= 0.8.7')

-  s.required_ruby_version = '>= 2.2.0'
+  s.required_ruby_version = '>= 2.3.0'


Cucumber-ruby supports >= 2.2, so we should change this back to keep things standardised.

xtrasimplicity · 2018-04-20T08:16:34Z

features/emulate_javascript.feature

@@ -16,12 +16,12 @@ Feature: Emulate Javascript
    And I write to "features/step_definitions/s.rb" with:
      """
      Given /^there is a widget named "([^"]*)"$/ do |name|
-        FactoryGirl.create(:widget, name: name)
+        FactoryBot.create(:widget, :name => name)


We shouldn't regress with this. :key => value is the old Ruby style. :)

xtrasimplicity · 2018-04-20T08:17:40Z

features/emulate_javascript.feature

@@ -73,12 +73,12 @@ Feature: Emulate Javascript
    And I write to "features/step_definitions/s.rb" with:
      """
      Given /^there is a widget named "([^"]*)"$/ do |name|
-        FactoryGirl.create(:widget, name: name)
+        FactoryBot.create(:widget, :name => name)


We shouldn't regress with this. :key => value is the old Ruby style. :)

…an '>=').

…831a)

mvz · 2018-04-20T14:32:39Z

cucumber-rails.gemspec

  s.add_development_dependency('rake', '>= 0.9.2.2')
-  s.add_development_dependency('rspec', '~> 3.0')
+  s.add_development_dependency('rspec', '~> 3')


This should become ~> 3.0 again to avoid allowing rspec 4 automatically when it arrives.

Woops. I'll fix that now - thanks @mvz!

mvz · 2018-04-20T14:33:00Z

Almost there \o/

aslakhellesoy · 2018-04-20T14:43:22Z

Hi @gobijan,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

xtrasimplicity · 2018-04-20T14:43:50Z

All merged! The last change wouldn't have any impact on the test suite. :)

gobijan · 2018-04-20T16:55:35Z

Nice! Thanks everyone for contributing on this 😀 Was fun to see open source at it's best.
Also thanks for adding me to the cucumber org @aslakhellesoy I'm happy to help out here and there :)

When working on cucumber/cucumber-rails#378, we would sometimes see that the builds would be unable to connect to the Geckodriver. On further investigation, this seems to be caused by the Geckodriver not being downloaded in the first place. I think that this is due to GitHub's API rate limiting certain build machines from accessing their API. A better approach would be to hardcode the URLs for the assets -- since they're easily predicatable -- and then to bump this gem whenever a new release comes out.

radar · 2018-04-21T02:32:51Z

Wonderful :)

I've opened a PR on DevicoSolutions/geckodriver-helper#5 which should hopefully put an end to the intermittent builds too.

radar · 2018-04-21T02:33:44Z

In the meantime, could we please get a new gem release containing this PR's fixes? I believe that would allow codebases that use cucumber-rails to also upgrade to Rails 5.2.

xtrasimplicity · 2018-04-21T02:37:19Z

@radar, we'll need to finalise the changelog first (#385), but once we've done this, we'll have to get @mvz, @olleolleolle, or @aslak to proceed with a release (when they're ready).

mvz · 2018-04-21T06:04:39Z

@xtrasimplicity That's a different Aslak 🙂

xtrasimplicity · 2018-04-21T06:15:47Z

Woops! Thanks @mvz.

@aslakhellesoy Would you be able to build the latest release and push it to rubygems.org, when you get a chance? (Or alternatively, could I have access to do this? 😀) Thanks heaps!

gobijan added 2 commits April 12, 2018 06:08

Relax railites to allow version 5.2.

416c543

Add gemfile for rails 5.2.

3bbb2a2

Update 5.2 gemspec dependencies to latest available ones. Allow railt…

238c391

…ies < 6.

gobijan added 4 commits April 12, 2018 08:20

Make travis use latest ruby releases.

6100eb4

Remove Ruby 2.2 from tests => EOL.

10084a9

Bump version to 1.6 (because removing EOL Ruby 2.2)

685413c

Add rails 5.2 to appraisals.

dc6a590

gobijan changed the title ~~Add Rails 5.2 support.~~ WIP: Add Rails 5.2 support. Apr 12, 2018

gobijan changed the title ~~WIP: Add Rails 5.2 support.~~ [WIP] Add Rails 5.2 support. Apr 12, 2018

mvz reviewed Apr 12, 2018

View reviewed changes

vovimayhem mentioned this pull request Apr 13, 2018

Rails 5.2 support #377

Closed

xtrasimplicity reviewed Apr 14, 2018

View reviewed changes

xtrasimplicity changed the title ~~[WIP] Add Rails 5.2 support.~~ [WIP] Add Rails 5.2 & Capybara 4 support. Apr 14, 2018

xtrasimplicity mentioned this pull request Apr 14, 2018

Support capybara 3.0 in gemspec file #379

Closed

radar reviewed Apr 17, 2018

View reviewed changes

Bump geckodriver-helper version to 0.0.5

937d44c

gobijan and others added 9 commits April 18, 2018 14:26

Relax railites to allow version 5.2.

1ef3b51

Add gemfile for rails 5.2.

0775efb

Update 5.2 gemspec dependencies to latest available ones. Allow railt…

8362a27

…ies < 6.

Make travis use latest ruby releases.

a6b99ea

Remove Ruby 2.2 from tests => EOL.

bd504a6

Bump version to 1.6 (because removing EOL Ruby 2.2)

4cd9f63

Add rails 5.2 to appraisals.

3b88c6b

factory_girl -> factory_bot

e942fd1

Fix other occurrences of factory_girl

4502e05

Merge pull request #4 from radar/click-with-js-emulation-args

4763fde

Make click_with_javascript_emulation take any args

xtrasimplicity requested changes Apr 20, 2018

View reviewed changes

xtrasimplicity reviewed Apr 20, 2018

View reviewed changes

xtrasimplicity added 4 commits April 20, 2018 18:19

Switched back to new hash key assignment syntax.

8fb4040

Re-added support for Ruby 2.2

1a85e85

Switched aruba dependency back to "strict" versioning ('~>' rather th…

dee9b75

…an '>=').

CI: force failed geckodriver -V commands to retry once.

eab831a

xtrasimplicity mentioned this pull request Apr 20, 2018

[WIP] Support Rails 5.2.X #376

Closed

6 tasks

Revert CI: force failed geckodriver -V commands to retry once. (eab…

9731f9b

…831a)

xtrasimplicity approved these changes Apr 20, 2018

View reviewed changes

mvz reviewed Apr 20, 2018

View reviewed changes

Fixed RSpec versioning

c480e62

xtrasimplicity merged commit a431927 into cucumber:master Apr 20, 2018

mvz changed the title ~~[WIP] Add Rails 5.2 & Capybara 3 support.~~ Add Rails 5.2 & Capybara 3 support. Apr 20, 2018

radar mentioned this pull request Apr 21, 2018

Hardcode download URLs DevicoSolutions/geckodriver-helper#5

Merged

varyonic mentioned this pull request Apr 22, 2018

factory_girl renamed to factory_bot #386

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Rails 5.2 & Capybara 3 support. #378

Add Rails 5.2 & Capybara 3 support. #378

gobijan commented Apr 12, 2018

mvz commented Apr 12, 2018

gobijan commented Apr 12, 2018

mvz Apr 12, 2018

mvz Apr 12, 2018

xtrasimplicity Apr 14, 2018

Kosmas Apr 14, 2018

roberts1000 commented Apr 14, 2018

radar Apr 17, 2018

radar Apr 17, 2018

radar Apr 17, 2018

radar commented Apr 17, 2018

gobijan commented Apr 20, 2018

xtrasimplicity commented Apr 20, 2018 via email •

edited

xtrasimplicity left a comment

xtrasimplicity Apr 20, 2018

xtrasimplicity Apr 20, 2018

xtrasimplicity Apr 20, 2018

mvz Apr 20, 2018

xtrasimplicity Apr 20, 2018

mvz commented Apr 20, 2018

aslakhellesoy commented Apr 20, 2018

xtrasimplicity commented Apr 20, 2018

gobijan commented Apr 20, 2018

radar commented Apr 21, 2018

radar commented Apr 21, 2018

xtrasimplicity commented Apr 21, 2018

mvz commented Apr 21, 2018

xtrasimplicity commented Apr 21, 2018 •

edited

Add Rails 5.2 & Capybara 3 support. #378

Add Rails 5.2 & Capybara 3 support. #378

Conversation

gobijan commented Apr 12, 2018

Summary

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

mvz commented Apr 12, 2018

gobijan commented Apr 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roberts1000 commented Apr 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radar commented Apr 17, 2018

gobijan commented Apr 20, 2018

xtrasimplicity commented Apr 20, 2018 via email • edited

xtrasimplicity left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mvz commented Apr 20, 2018

aslakhellesoy commented Apr 20, 2018

xtrasimplicity commented Apr 20, 2018

gobijan commented Apr 20, 2018

radar commented Apr 21, 2018

radar commented Apr 21, 2018

xtrasimplicity commented Apr 21, 2018

mvz commented Apr 21, 2018

xtrasimplicity commented Apr 21, 2018 • edited

xtrasimplicity commented Apr 20, 2018 via email •

edited

xtrasimplicity commented Apr 21, 2018 •

edited