[Core] Don't swallow parse errors on the CLI #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2632 +/- ##
=========================================
Coverage 84.79% 84.79%
Complexity 2693 2693
=========================================
Files 322 322
Lines 9544 9544
Branches 908 908
=========================================
Hits 8093 8093
Misses 1120 1120
Partials 331 331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mpkorstanje
force-pushed
the
do-not-swallow-parse-errors
branch
from
c6f22f4
to
40b3145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 What's changed?
With v7.6.0 in 3bc80b9 before all and after
all hooks were introduced. This moved parsing of features into the execution
context. This resulted in any parse errors being swallowed with the assumption
that they would have been captured by the execution context already.
Fixes: #2631