[Core] Fix usage formatter serialization #2392
Merged
+54
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage formatter is re(ab)using the json formatter from messages. While it is technically feasible to come up with a solution that does not do this it would be better to redesign the formatter with a table-like human-readable output in mind. As such we can defer this decision to a later point in time.
mpkorstanje
force-pushed
the
fix-usage-formatter-serialization
branch
from
becac9b to
458c925
Compare
Codecov Report
@@ Coverage Diff @@
## main #2392 +/- ##
=========================================
Coverage 83.53% 83.53%
Complexity 2623 2623
=========================================
Files 316 316
Lines 9306 9306
Branches 902 902
=========================================
Hits 7774 7774
Misses 1197 1197
Partials 335 335
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage formatter is re(ab)using the json formatter from messages. While it
is technically feasible to come up with a solution that does not do this it
would be better to redesign the formatter with a table-like human-readable
output in mind. As such we can defer this decision to a later point in time.
Fixes: #2381