Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frozen option #603

Merged
merged 1 commit into from Apr 8, 2019
Merged

Add frozen option #603

merged 1 commit into from Apr 8, 2019

Conversation

yokomotod
Copy link
Contributor

@yokomotod yokomotod commented Feb 23, 2019

fix #317

Add --frozen option to abort instead of write annotation.
This is mainly for CI environment to detect missing annotation.
Similar motivation with bundle install --frozen.

works like:

$ rake db:migrate frozen=yes
..
annotate error. spec/models/user_spec.rb needs to be updated, but annotate was run with `--frozen`.

@yokomotod yokomotod mentioned this pull request Feb 23, 2019
@@ -22,6 +22,7 @@ has_set_position = {}
target_action = :do_annotations
positions = %w(before top after bottom)

# rubocop:disable Metrics/BlockLength
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note]

finally it reached to

bin/annotate:25:1: C: Metrics/BlockLength: Block has too many lines. [145/142]

and I thought it's rational to suppress here IMO

@ctran ctran added this to the v.2.7.5 milestone Apr 8, 2019
@ctran ctran added the feature label Apr 8, 2019
@ctran ctran merged commit fe17228 into ctran:develop Apr 8, 2019
@percyhanna
Copy link

This PR looks great, and would be a great addition to an awesome gem. Just wondering if version 2.7.5 has been officially released yet? The link in the changelog 404's, and version 2.7.5 has not been published to RubyGems.

Thanks for the great work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: CI Support
3 participants