Refactor hooking ActiveRecord migration tasks #588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 changes:
Use
Rake::Task#enhance
insteaad of defining same tasks again.Remove hooking
db:migrate:change
task which doesn't exist. This hook has been added by Support :change migrations in Rails 3.1 #42, but as far as I searched I can't find the task in Rails 3.1 or greater version.Fix hooking
db:migrate:redo
task so that the annotation runs after all migration tasks. Closedb:migrate:redo
reverses the annotation but doesn't redo it #548.This is done by hooking the top level task to run the annnotation. (ref: https://stackoverflow.com/a/3915951)