Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: CI Support #317

Closed
DamirSvrtan opened this issue Jan 14, 2016 · 3 comments · Fixed by #603
Closed

Question: CI Support #317

DamirSvrtan opened this issue Jan 14, 2016 · 3 comments · Fixed by #603
Labels
feature

Comments

@DamirSvrtan
Copy link

We often forget to roll annotations. Is there a way to let annotate_models check if everything is annotated and if that isn't true, throw an abort so our CI build fails.

Thnx upfront.
@ctran ctran added the feature label Jan 16, 2016
@ctran
Copy link
Owner

ctran commented Jan 16, 2016

I don't think there's currently possible. It may require some tweaks to support.

I never thought this gem would be part of a CI step though :-)

@ctran
Copy link
Owner

ctran commented Feb 14, 2019

PR is welcome but I'm closing this.

@ctran ctran closed this as completed Feb 14, 2019
@yokomotod yokomotod mentioned this issue Feb 23, 2019
Merged
@yokomotod
Copy link
Contributor

+1 for this motivation and tried to submit PR #603

very often I met changing annotations just after pull master and run migrate
because someone (sometimes, myself 😝) forgot to commit annotations...
I really want to detect it on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add frozen option yokomotod/annotate_models
3 participants
@ctran @yokomotod @DamirSvrtan