From a9a2e970513d394e655ccc6c53e25cb5081392f9 Mon Sep 17 00:00:00 2001 From: "Andrew W. Lee" Date: Mon, 8 Apr 2019 11:15:38 -0700 Subject: [PATCH] Update Rubocop version (#608) * Update rubocop requirement from ~> 0.46.0 to ~> 0.65.0 Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.46.0...v0.65.0) Signed-off-by: dependabot[bot] * Regenerate .rubocop_todo.yml --- .rubocop_todo.yml | 731 +++++++++++++++++++++++++++++++++------------- Gemfile | 2 +- 2 files changed, 526 insertions(+), 207 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5828f8aee..578f1b345 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2017-10-13 10:01:18 +0200 using RuboCop version 0.46.0. +# on 2019-03-07 18:25:02 -0800 using RuboCop version 0.65.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -8,7 +8,7 @@ # Offense count: 9 # Configuration parameters: Include. -# Include: **/Gemfile, **/gems.rb +# Include: **/*.gemfile, **/Gemfile, **/gems.rb Bundler/DuplicatedGem: Exclude: - 'spec/integration/rails_2.3_with_bundler/Gemfile' @@ -22,13 +22,326 @@ Bundler/DuplicatedGem: - 'spec/integration/standalone/Gemfile' # Offense count: 2 -# Configuration parameters: Include. -# Include: **/Gemfile, **/gems.rb +# Cop supports --auto-correct. +# Configuration parameters: TreatCommentsAsGroupSeparators, Include. +# Include: **/*.gemfile, **/Gemfile, **/gems.rb Bundler/OrderedGems: Exclude: - 'spec/integration/rails_2.3_with_bundler/Gemfile' - 'spec/integration/rails_3.2_with_asset_pipeline/Gemfile' +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: TreatCommentsAsGroupSeparators, Include. +# Include: **/*.gemspec +Gemspec/OrderedDependencies: + Exclude: + - 'annotate.gemspec' + +# Offense count: 1 +# Configuration parameters: Include. +# Include: **/*.gemspec +Gemspec/RequiredRubyVersion: + Exclude: + - 'annotate.gemspec' + +# Offense count: 2 +# Cop supports --auto-correct. +Layout/AlignArray: + Exclude: + - 'spec/annotate/annotate_models_spec.rb' + +# Offense count: 103 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. +# SupportedHashRocketStyles: key, separator, table +# SupportedColonStyles: key, separator, table +# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit +Layout/AlignHash: + Exclude: + - 'lib/generators/annotate/templates/auto_annotate_models.rake' + - 'spec/annotate/annotate_models_spec.rb' + - 'spec/integration/rails_2.3_with_bundler/config/initializers/unified_initializer.rb' + - 'spec/integration/rails_4.1.1/lib/tasks/auto_annotate_models.rake' + - 'spec/integration/rails_4.2.0/lib/tasks/auto_annotate_models.rake' + - 'spec/integration/standalone/config/init.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyleAlignWith. +# SupportedStylesAlignWith: either, start_of_block, start_of_line +Layout/BlockAlignment: + Exclude: + - 'lib/annotate/annotate_models.rb' + +# Offense count: 45 +# Cop supports --auto-correct. +Layout/ClosingHeredocIndentation: + Exclude: + - 'spec/annotate/annotate_models_spec.rb' + - 'spec/integration/rails_2.3_with_bundler.rb' + - 'spec/integration/rails_3.2.2.rb' + - 'spec/integration/rails_3.2.8.rb' + - 'spec/integration/rails_3.2_autoloading_factory_girl.rb' + - 'spec/integration/rails_3.2_custom_inflections.rb' + - 'spec/integration/rails_3.2_with_asset_pipeline.rb' + - 'spec/integration/standalone.rb' + +# Offense count: 14 +# Cop supports --auto-correct. +Layout/EmptyLineAfterGuardClause: + Exclude: + - 'Rakefile' + - 'lib/annotate.rb' + - 'lib/annotate/annotate_models.rb' + - 'lib/annotate/annotate_routes.rb' + - 'spec/integration/integration_spec.rb' + +# Offense count: 10 +# Cop supports --auto-correct. +Layout/EmptyLineAfterMagicComment: + Exclude: + - 'annotate.gemspec' + - 'spec/annotate/annotate_models_spec.rb' + - 'spec/integration/rails_3.2.2/db/schema.rb' + - 'spec/integration/rails_3.2.8/db/schema.rb' + - 'spec/integration/rails_3.2_autoloading_factory_girl/db/schema.rb' + - 'spec/integration/rails_3.2_custom_inflections/db/schema.rb' + - 'spec/integration/rails_3.2_with_asset_pipeline/db/schema.rb' + - 'spec/integration/rails_4.1.1/db/schema.rb' + - 'spec/integration/rails_4.2.0/db/schema.rb' + - 'spec/integration/standalone/db/schema.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +Layout/EmptyLines: + Exclude: + - 'spec/integration/rails_4.1.1/Gemfile' + - 'spec/integration/rails_4.2.0/Gemfile' + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/EmptyLinesAroundAccessModifier: + Exclude: + - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +Layout/EmptyLinesAroundArguments: + Exclude: + - 'spec/annotate/annotate_routes_spec.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: empty_lines, no_empty_lines +Layout/EmptyLinesAroundBlockBody: + Exclude: + - 'spec/integration/rails_2.3_with_bundler/db/schema.rb' + - 'spec/integration/rails_4.1.1/db/schema.rb' + - 'spec/integration/rails_4.2.0/db/schema.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/EmptyLinesAroundExceptionHandlingKeywords: + Exclude: + - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' + +# Offense count: 24 +# Cop supports --auto-correct. +# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. +Layout/ExtraSpacing: + Exclude: + - 'Guardfile' + - 'lib/annotate/annotate_models.rb' + - 'lib/tasks/annotate_routes.rake' + - 'spec/integration/rails_2.3_with_bundler/script/console' + - 'spec/integration/rails_3.2.2/script/rails' + - 'spec/integration/rails_3.2.8/script/rails' + - 'spec/integration/rails_3.2_autoloading_factory_girl/script/rails' + - 'spec/integration/rails_3.2_custom_inflections/script/rails' + - 'spec/integration/rails_3.2_with_asset_pipeline/script/rails' + - 'spec/integration/rails_4.1.1/Gemfile' + - 'spec/integration/rails_4.1.1/config.ru' + - 'spec/integration/rails_4.2.0/Gemfile' + - 'spec/integration/rails_4.2.0/config.ru' + +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: IndentationWidth. +# SupportedStyles: special_inside_parentheses, consistent, align_braces +Layout/IndentHash: + EnforcedStyle: consistent + +# Offense count: 54 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent +Layout/IndentHeredoc: + Exclude: + - 'spec/annotate/annotate_models_spec.rb' + - 'spec/integration/integration_spec.rb' + - 'spec/integration/rails_2.3_with_bundler.rb' + - 'spec/integration/rails_3.2.2.rb' + - 'spec/integration/rails_3.2.8.rb' + - 'spec/integration/rails_3.2_autoloading_factory_girl.rb' + - 'spec/integration/rails_3.2_custom_inflections.rb' + - 'spec/integration/rails_3.2_with_asset_pipeline.rb' + - 'spec/integration/standalone.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: normal, rails +Layout/IndentationConsistency: + Exclude: + - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' + +# Offense count: 5 +# Cop supports --auto-correct. +# Configuration parameters: Width, IgnoredPatterns. +Layout/IndentationWidth: + Exclude: + - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' + - 'spec/integration/rails_4.1.1/app/models/sub1/sub2/sub3/event.rb' + - 'spec/integration/rails_4.1.1/app/models/task.rb' + - 'spec/integration/rails_4.2.0/app/models/sub1/sub2/sub3/event.rb' + - 'spec/integration/rails_4.2.0/app/models/task.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: aligned, indented, indented_relative_to_receiver +Layout/MultilineMethodCallIndentation: + Exclude: + - 'spec/annotate/annotate_routes_spec.rb' + +# Offense count: 5 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: aligned, indented +Layout/MultilineOperationIndentation: + Exclude: + - 'lib/annotate/annotate_models.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: space, no_space +Layout/SpaceAroundEqualsInParameterDefault: + Exclude: + - 'lib/annotate/annotate_routes.rb' + - 'spec/integration/common_validation.rb' + +# Offense count: 9 +# Cop supports --auto-correct. +Layout/SpaceAroundKeyword: + Exclude: + - 'spec/integration/rails_2.3_with_bundler/Gemfile' + - 'spec/integration/rails_3.2.2/Gemfile' + - 'spec/integration/rails_3.2.8/Gemfile' + - 'spec/integration/rails_3.2_autoloading_factory_girl/Gemfile' + - 'spec/integration/rails_3.2_custom_inflections/Gemfile' + - 'spec/integration/rails_3.2_with_asset_pipeline/Gemfile' + - 'spec/integration/rails_4.1.1/Gemfile' + - 'spec/integration/rails_4.2.0/Gemfile' + - 'spec/integration/standalone/Gemfile' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: AllowForAlignment. +Layout/SpaceAroundOperators: + Exclude: + - 'lib/annotate/annotate_models.rb' + - 'lib/tasks/annotate_routes.rake' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceBeforeBlockBraces: + Exclude: + - 'lib/annotate/annotate_models.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/SpaceBeforeComment: + Exclude: + - 'lib/annotate/annotate_models.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. +# SupportedStyles: space, no_space, compact +# SupportedStylesForEmptyBrackets: space, no_space +Layout/SpaceInsideArrayLiteralBrackets: + Exclude: + - 'spec/integration/rails_2.3_with_bundler/config/environment.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideBlockBraces: + Exclude: + - 'lib/annotate/annotate_models.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space, compact +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideHashLiteralBraces: + Exclude: + - 'lib/tasks/annotate_models.rake' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: space, no_space +Layout/SpaceInsideParens: + Exclude: + - 'lib/annotate/annotate_models.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: space, no_space +Layout/SpaceInsideStringInterpolation: + Exclude: + - 'lib/annotate/annotate_models.rb' + +# Offense count: 6 +# Cop supports --auto-correct. +# Configuration parameters: IndentationWidth. +Layout/Tab: + Exclude: + - 'spec/integration/rails_4.1.1/app/models/sub1/sub2/sub3/event.rb' + - 'spec/integration/rails_4.1.1/app/models/task.rb' + - 'spec/integration/rails_4.2.0/app/models/sub1/sub2/sub3/event.rb' + - 'spec/integration/rails_4.2.0/app/models/task.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: final_newline, final_blank_line +Layout/TrailingBlankLines: + Exclude: + - 'spec/integration/rails_4.1.1/app/models/task_observer.rb' + - 'spec/integration/rails_4.1.1/config/initializers/cookies_serializer.rb' + - 'spec/integration/rails_4.2.0/app/models/task_observer.rb' + - 'spec/integration/rails_4.2.0/config/initializers/cookies_serializer.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: AllowInHeredoc. +Layout/TrailingWhitespace: + Exclude: + - 'spec/annotate/annotate_routes_spec.rb' + - 'spec/integration/rails_2.3_with_bundler/db/schema.rb' + # Offense count: 3 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: @@ -36,13 +349,11 @@ Lint/AssignmentInCondition: - 'lib/annotate/annotate_models.rb' - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. -# Configuration parameters: AlignWith, SupportedStyles. -# SupportedStyles: either, start_of_block, start_of_line -Lint/BlockAlignment: +Lint/BigDecimalNew: Exclude: - - 'lib/annotate/annotate_models.rb' + - 'spec/annotate/annotate_models_spec.rb' # Offense count: 6 # Cop supports --auto-correct. @@ -67,17 +378,35 @@ Lint/HandleExceptions: # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: EnforcedStyle. # SupportedStyles: runtime_error, standard_error Lint/InheritException: Exclude: - 'lib/annotate/annotate_models.rb' +# Offense count: 3 +# Configuration parameters: MaximumRangeSize. +Lint/MissingCopEnableDirective: + Exclude: + - 'lib/annotate.rb' + - 'lib/annotate/annotate_models.rb' + - 'lib/annotate/annotate_routes.rb' + # Offense count: 2 Lint/RescueException: Exclude: - 'Rakefile' +# Offense count: 5 +# Cop supports --auto-correct. +Lint/ScriptPermission: + Exclude: + - 'spec/integration/rails_3.2.2/Rakefile' + - 'spec/integration/rails_3.2.8/Rakefile' + - 'spec/integration/rails_3.2_autoloading_factory_girl/Rakefile' + - 'spec/integration/rails_3.2_custom_inflections/Rakefile' + - 'spec/integration/rails_3.2_with_asset_pipeline/Rakefile' + # Offense count: 1 Lint/ShadowingOuterLocalVariable: Exclude: @@ -92,50 +421,78 @@ Lint/UnusedBlockArgument: # Offense count: 18 Metrics/AbcSize: - Max: 142 + Max: 139 -# Offense count: 3 -# Configuration parameters: CountComments. +# Offense count: 29 +# Configuration parameters: CountComments, ExcludedMethods. +# ExcludedMethods: refine Metrics/BlockLength: - Max: 142 + Max: 1140 -# Offense count: 2 +# Offense count: 1 +# Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 4 -# Offense count: 9 +# Offense count: 10 Metrics/CyclomaticComplexity: Max: 36 -# Offense count: 380 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 276 - -# Offense count: 26 -# Configuration parameters: CountComments. +# Offense count: 29 +# Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: Max: 75 -# Offense count: 7 +# Offense count: 8 Metrics/PerceivedComplexity: Max: 42 # Offense count: 1 -Style/AccessorMethodName: +Naming/AccessorMethodName: Exclude: - 'lib/annotate.rb' +# Offense count: 76 +# Configuration parameters: Blacklist. +# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$)) +Naming/HeredocDelimiterNaming: + Exclude: + - 'spec/annotate/annotate_models_spec.rb' + - 'spec/annotate/annotate_routes_spec.rb' + # Offense count: 2 +# Configuration parameters: EnforcedStyleForLeadingUnderscores. +# SupportedStylesForLeadingUnderscores: disallowed, required, optional +Naming/MemoizedInstanceVariableName: + Exclude: + - 'lib/annotate/annotate_routes.rb' + - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' + +# Offense count: 1 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: io, id, to, by, on, in, at, ip, db +Naming/UncommunicativeMethodParamName: + Exclude: + - 'Rakefile' + +# Offense count: 4 # Cop supports --auto-correct. -Style/AlignArray: +Performance/RegexpMatch: Exclude: - - 'spec/annotate/annotate_models_spec.rb' + - 'lib/annotate/annotate_models.rb' + - 'lib/annotate/annotate_routes.rb' + - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' + +# Offense count: 1 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: inline, group +Style/AccessModifierDeclarations: + Exclude: + - 'lib/annotate/annotate_models.rb' # Offense count: 2 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: EnforcedStyle. # SupportedStyles: percent_q, bare_percent Style/BarePercentLiterals: Exclude: @@ -143,7 +500,7 @@ Style/BarePercentLiterals: # Offense count: 3 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: EnforcedStyle. # SupportedStyles: braces, no_braces, context_dependent Style/BracesAroundHashParameters: Exclude: @@ -157,7 +514,8 @@ Style/CaseEquality: - 'lib/annotate/annotate_models.rb' # Offense count: 14 -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, EnforcedStyle. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: Exclude: @@ -183,12 +541,18 @@ Style/ClassVars: # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly. +# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. # SupportedStyles: assign_to_condition, assign_inside_condition Style/ConditionalAssignment: Exclude: - 'bin/annotate' +# Offense count: 1 +# Cop supports --auto-correct. +Style/Dir: + Exclude: + - 'bin/annotate' + # Offense count: 7 Style/Documentation: Exclude: @@ -201,102 +565,96 @@ Style/Documentation: - 'lib/generators/annotate/install_generator.rb' - 'lib/tasks/annotate_models_migrate.rake' -# Offense count: 2 -# Cop supports --auto-correct. -Style/EmptyLines: - Exclude: - - 'spec/integration/rails_4.1.1/Gemfile' - - 'spec/integration/rails_4.2.0/Gemfile' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/EmptyLinesAroundAccessModifier: - Exclude: - - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' - -# Offense count: 6 +# Offense count: 10 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: empty_lines, no_empty_lines -Style/EmptyLinesAroundBlockBody: +Style/Encoding: Exclude: - - 'spec/integration/rails_2.3_with_bundler/db/schema.rb' + - 'annotate.gemspec' + - 'spec/annotate/annotate_models_spec.rb' + - 'spec/integration/rails_3.2.2/db/schema.rb' + - 'spec/integration/rails_3.2.8/db/schema.rb' + - 'spec/integration/rails_3.2_autoloading_factory_girl/db/schema.rb' + - 'spec/integration/rails_3.2_custom_inflections/db/schema.rb' + - 'spec/integration/rails_3.2_with_asset_pipeline/db/schema.rb' - 'spec/integration/rails_4.1.1/db/schema.rb' - 'spec/integration/rails_4.2.0/db/schema.rb' + - 'spec/integration/standalone/db/schema.rb' -# Offense count: 23 +# Offense count: 48 # Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. -Style/ExtraSpacing: - Exclude: - - 'Guardfile' - - 'lib/annotate/annotate_models.rb' - - 'lib/tasks/annotate_routes.rake' - - 'spec/integration/rails_2.3_with_bundler/script/console' - - 'spec/integration/rails_3.2.2/script/rails' - - 'spec/integration/rails_3.2.8/script/rails' - - 'spec/integration/rails_3.2_autoloading_factory_girl/script/rails' - - 'spec/integration/rails_3.2_custom_inflections/script/rails' - - 'spec/integration/rails_3.2_with_asset_pipeline/script/rails' - - 'spec/integration/rails_4.1.1/Gemfile' - - 'spec/integration/rails_4.1.1/config.ru' - - 'spec/integration/rails_4.2.0/Gemfile' - - 'spec/integration/rails_4.2.0/config.ru' +Style/ExpandPathArguments: + Enabled: false # Offense count: 10 -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. # SupportedStyles: format, sprintf, percent Style/FormatString: Exclude: - 'lib/annotate/annotate_models.rb' - 'lib/annotate/annotate_routes.rb' -# Offense count: 7 +# Offense count: 23 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: annotated, template, unannotated +Style/FormatStringToken: + Exclude: + - 'lib/annotate/annotate_models.rb' + +# Offense count: 184 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: when_needed, always, never +Style/FrozenStringLiteralComment: + Enabled: false + +# Offense count: 5 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: - - 'lib/annotate/annotate_models.rb' - 'lib/annotate/annotate_routes.rb' - 'lib/tasks/annotate_models_migrate.rake' - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' # Offense count: 57 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. +# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys Style/HashSyntax: Enabled: false -# Offense count: 6 +# Offense count: 11 # Cop supports --auto-correct. -# Configuration parameters: SupportedStyles, IndentationWidth. -# SupportedStyles: special_inside_parentheses, consistent, align_braces -Style/IndentHash: - EnforcedStyle: consistent +Style/IfUnlessModifier: + Exclude: + - 'Rakefile' + - 'bin/annotate' + - 'lib/annotate/annotate_models.rb' + - 'lib/annotate/annotate_routes.rb' # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: normal, rails -Style/IndentationConsistency: +# Configuration parameters: InverseMethods, InverseBlocks. +Style/InverseMethods: Exclude: - - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' + - 'Rakefile' -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: Width. -Style/IndentationWidth: +# Offense count: 1 +Style/MethodMissingSuper: Exclude: - - 'spec/integration/rails_4.1.1/app/models/sub1/sub2/sub3/event.rb' - - 'spec/integration/rails_4.1.1/app/models/task.rb' - - 'spec/integration/rails_4.2.0/app/models/sub1/sub2/sub3/event.rb' - - 'spec/integration/rails_4.2.0/app/models/task.rb' + - 'lib/annotate/active_record_patch.rb' # Offense count: 1 -Style/MethodMissing: +Style/MissingRespondToMissing: Exclude: - 'lib/annotate/active_record_patch.rb' +# Offense count: 3 +Style/MixinUsage: + Exclude: + - 'Rakefile' + - 'spec/integration/integration_spec.rb' + # Offense count: 3 Style/MultilineBlockChain: Exclude: @@ -306,37 +664,60 @@ Style/MultilineBlockChain: # Offense count: 5 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. -# SupportedStyles: aligned, indented -Style/MultilineOperationIndentation: - Exclude: - - 'lib/annotate/annotate_models.rb' - -# Offense count: 3 -# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: literals, strict Style/MutableConstant: Exclude: + - 'lib/annotate.rb' + - 'lib/annotate/annotate_models.rb' - 'lib/annotate/annotate_routes.rb' - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' - 'spec/integration/rails_2.3_with_bundler/config/environment.rb' # Offense count: 1 # Cop supports --auto-correct. +# Configuration parameters: Whitelist. +# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with Style/NestedParenthesizedCalls: Exclude: - 'bin/annotate' # Offense count: 9 # Cop supports --auto-correct. +# Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 15 # Offense count: 2 # Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. +# SupportedStyles: predicate, comparison +Style/NumericPredicate: + Exclude: + - 'spec/**/*' + - 'lib/annotate.rb' + - 'lib/annotate/annotate_models.rb' + +# Offense count: 24 +# Cop supports --auto-correct. # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: Exclude: - 'annotate.gemspec' + - 'bin/annotate' + - 'lib/annotate/annotate_models.rb' + - 'lib/annotate/annotate_routes.rb' + - 'lib/tasks/annotate_models_migrate.rake' + - 'spec/annotate/annotate_models_spec.rb' + - 'spec/integration/rails_3.2.2/config/application.rb' + - 'spec/integration/rails_3.2.8/config/application.rb' + - 'spec/integration/rails_3.2_autoloading_factory_girl/config/application.rb' + - 'spec/integration/rails_3.2_custom_inflections/config/application.rb' + - 'spec/integration/rails_3.2_with_asset_pipeline/config/application.rb' + - 'spec/integration/rails_4.1.1/app/models/task.rb' + - 'spec/integration/rails_4.2.0/app/models/task.rb' + - 'spec/spec_helper.rb' + - 'spec/tasks/annotate_models_migrate_spec.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -346,17 +727,18 @@ Style/PerlBackrefs: # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: EnforcedStyle. # SupportedStyles: compact, exploded Style/RaiseArgs: Exclude: - 'lib/annotate/annotate_models.rb' -# Offense count: 1 +# Offense count: 3 # Cop supports --auto-correct. Style/RedundantBegin: Exclude: - 'lib/annotate/annotate_models.rb' + - 'spec/annotate/annotate_models_spec.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -377,9 +759,9 @@ Style/RedundantSelf: Exclude: - 'lib/tasks/annotate_models_migrate.rake' -# Offense count: 12 +# Offense count: 13 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. +# Configuration parameters: EnforcedStyle, AllowInnerSlashes. # SupportedStyles: slashes, percent_r, mixed Style/RegexpLiteral: Exclude: @@ -394,152 +776,83 @@ Style/RescueModifier: - 'lib/annotate/annotate_models.rb' - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: AllowAsExpressionSeparator. -Style/Semicolon: - Exclude: - - 'bin/annotate' - - 'spec/integration/rails_2.3_with_bundler/config/initializers/unified_initializer.rb' - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: space, no_space -Style/SpaceAroundEqualsInParameterDefault: - Exclude: - - 'lib/annotate/annotate_routes.rb' - - 'spec/integration/common_validation.rb' - -# Offense count: 9 -# Cop supports --auto-correct. -Style/SpaceAroundKeyword: - Exclude: - - 'spec/integration/rails_2.3_with_bundler/Gemfile' - - 'spec/integration/rails_3.2.2/Gemfile' - - 'spec/integration/rails_3.2.8/Gemfile' - - 'spec/integration/rails_3.2_autoloading_factory_girl/Gemfile' - - 'spec/integration/rails_3.2_custom_inflections/Gemfile' - - 'spec/integration/rails_3.2_with_asset_pipeline/Gemfile' - - 'spec/integration/rails_4.1.1/Gemfile' - - 'spec/integration/rails_4.2.0/Gemfile' - - 'spec/integration/standalone/Gemfile' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment. -Style/SpaceAroundOperators: - Exclude: - - 'lib/annotate/annotate_models.rb' - - 'lib/tasks/annotate_routes.rake' - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: space, no_space -Style/SpaceBeforeBlockBraces: - Exclude: - - 'lib/annotate/annotate_models.rb' - # Offense count: 1 # Cop supports --auto-correct. -Style/SpaceBeforeComment: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: implicit, explicit +Style/RescueStandardError: Exclude: - - 'lib/annotate/annotate_models.rb' + - 'lib/annotate.rb' -# Offense count: 4 +# Offense count: 2 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. -# SupportedStyles: space, no_space -Style/SpaceInsideBlockBraces: +# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist. +# Whitelist: present?, blank?, presence, try, try! +Style/SafeNavigation: Exclude: - 'lib/annotate/annotate_models.rb' # Offense count: 2 # Cop supports --auto-correct. -Style/SpaceInsideBrackets: - Exclude: - - 'spec/integration/rails_2.3_with_bundler/config/environment.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles. -# SupportedStyles: space, no_space, compact -Style/SpaceInsideHashLiteralBraces: - Exclude: - - 'lib/tasks/annotate_models.rake' - -# Offense count: 4 -# Cop supports --auto-correct. -Style/SpaceInsideParens: +# Configuration parameters: AllowAsExpressionSeparator. +Style/Semicolon: Exclude: - - 'lib/annotate/annotate_models.rb' + - 'bin/annotate' + - 'spec/integration/rails_2.3_with_bundler/config/initializers/unified_initializer.rb' -# Offense count: 2 +# Offense count: 18 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: space, no_space -Style/SpaceInsideStringInterpolation: +Style/StderrPuts: Exclude: + - 'Rakefile' + - 'lib/annotate.rb' - 'lib/annotate/annotate_models.rb' + - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' -# Offense count: 237 +# Offense count: 240 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. +# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Enabled: false # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: EnforcedStyle. # SupportedStyles: single_quotes, double_quotes Style/StringLiteralsInInterpolation: Exclude: - 'lib/annotate/annotate_models.rb' +# Offense count: 10 +# Cop supports --auto-correct. +# Configuration parameters: MinSize. +# SupportedStyles: percent, brackets +Style/SymbolArray: + EnforcedStyle: brackets + # Offense count: 1 # Cop supports --auto-correct. Style/SymbolLiteral: Exclude: - 'spec/annotate/annotate_models_spec.rb' -# Offense count: 6 -# Cop supports --auto-correct. -Style/Tab: - Exclude: - - 'spec/integration/rails_4.1.1/app/models/sub1/sub2/sub3/event.rb' - - 'spec/integration/rails_4.1.1/app/models/task.rb' - - 'spec/integration/rails_4.2.0/app/models/sub1/sub2/sub3/event.rb' - - 'spec/integration/rails_4.2.0/app/models/task.rb' - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: final_newline, final_blank_line -Style/TrailingBlankLines: - Exclude: - - 'spec/integration/rails_4.1.1/app/models/task_observer.rb' - - 'spec/integration/rails_4.1.1/config/initializers/cookies_serializer.rb' - - 'spec/integration/rails_4.2.0/app/models/task_observer.rb' - - 'spec/integration/rails_4.2.0/config/initializers/cookies_serializer.rb' - -# Offense count: 3 +# Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles. -# SupportedStyles: comma, consistent_comma, no_comma -Style/TrailingCommaInLiteral: +# Configuration parameters: EnforcedStyleForMultiline. +# SupportedStylesForMultiline: comma, consistent_comma, no_comma +Style/TrailingCommaInArrayLiteral: Exclude: - 'spec/annotate/annotate_models_spec.rb' - - 'spec/integration/rails_4.1.1/lib/tasks/auto_annotate_models.rake' - - 'spec/integration/rails_4.2.0/lib/tasks/auto_annotate_models.rake' # Offense count: 2 # Cop supports --auto-correct. -Style/TrailingWhitespace: +# Configuration parameters: EnforcedStyleForMultiline. +# SupportedStylesForMultiline: comma, consistent_comma, no_comma +Style/TrailingCommaInHashLiteral: Exclude: - - 'spec/annotate/annotate_routes_spec.rb' - - 'spec/integration/rails_2.3_with_bundler/db/schema.rb' + - 'spec/integration/rails_4.1.1/lib/tasks/auto_annotate_models.rake' + - 'spec/integration/rails_4.2.0/lib/tasks/auto_annotate_models.rake' # Offense count: 2 # Cop supports --auto-correct. @@ -553,3 +866,9 @@ Style/UnneededPercentQ: Exclude: - 'annotate.gemspec' - 'spec/integration/rails_2.3_with_bundler/config/boot.rb' + +# Offense count: 424 +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Metrics/LineLength: + Max: 276 diff --git a/Gemfile b/Gemfile index 8b466be60..ebdd3846e 100644 --- a/Gemfile +++ b/Gemfile @@ -19,7 +19,7 @@ group :development, :test do gem 'guard-rspec', require: false gem 'rspec', require: false - gem 'rubocop', '~> 0.46.0', require: false unless RUBY_VERSION =~ /^1.8/ + gem 'rubocop', '~> 0.65.0', require: false unless RUBY_VERSION =~ /^1.8/ gem 'simplecov', require: false gem 'terminal-notifier-guard', require: false