Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

By default only show System Trust discrepancies #520

Open
jw3 opened this issue Jun 29, 2022 · 3 comments · May be fixed by #763
Open

By default only show System Trust discrepancies #520

jw3 opened this issue Jun 29, 2022 · 3 comments · May be fixed by #763
Assignees
@egbicker
Labels
Needs Verified Need additional feedback to ensure validity of issue. Needs Wireframe GUI design and mockup needed trust ui Work related to the UI

Comments

@jw3
Copy link
Member

jw3 commented Jun 29, 2022

A thought on reducing startup time is to default the display of System trust to only show discrepancies. An additional action would be required to include trusted files in the display.

  1. Trusted files are less interesting
  2. The mass of trusted files is usually where latency comes from
  3. We dont have an "Untrust" action, so there is nothing you can do with a trusted file anyways

An additional action to show trusted could be

  1. "Show all" check box
  2. Use of the search field

This is targeting the latency in the table model and view only, the backend would still generate all metadata.
@jw3 jw3 added trust ui Work related to the UI Needs Verified Need additional feedback to ensure validity of issue. labels Jun 29, 2022
@jw3 jw3 mentioned this issue Jul 29, 2022
Open
@jw3 jw3 added this to the 8 milestone Jul 29, 2022
@jw3 jw3 added the Needs Wireframe GUI design and mockup needed label Sep 1, 2022
@jw3 jw3 modified the milestones: v1.0, v1.1 Oct 31, 2022
@jw3 jw3 mentioned this issue Jan 10, 2023
Closed
@jw3 jw3 mentioned this issue Jan 26, 2023
Open
@egbicker egbicker self-assigned this Jan 26, 2023
@egbicker
Copy link
Contributor

egbicker commented Jan 30, 2023 •
edited

I think updating the treeview to show hidden trusted files from the search bar will make more sense to implement once #738 is merged and we can use the Enter key to load that specific entry if it exists.

@jw3 On the call Thursday you made it seem like there was maybe more to this issue. I have only the discrepancies showing on startup with a toggle button in the action toolbar that is wired up and seems to be working.

@jw3
Copy link
Member Author

jw3 commented Jan 30, 2023

One thing was that if there are no discrepancies the table will be empty, which may be confusing as to what is going on.

In the case of the empty table it would be nice to display a concise message that informs user that there are no discrepancies and that they can search to display trusted entries.

In the case of 1 or more discrepancies no message is needed.

This is not a popup dialog, its something that overlays cleanly on the table itself. Like an overlay component that places a label on top of the table.

@jw3
Copy link
Member Author

jw3 commented Jan 30, 2023

If the overlay is reusable then it can be used for similar purpose on ancillary trust view to let user know to add trust entries.

@egbicker egbicker linked a pull request Feb 23, 2023 that will close this issue
Show trust discrepancies by default #763
Open
@jw3 jw3 linked a pull request Mar 2, 2023 that will close this issue
Open
@jw3 jw3 modified the milestones: v1.1, v1.2 Jun 24, 2023
@jw3 jw3 removed this from the v1.2 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egbicker egbicker

Labels
Needs Verified Need additional feedback to ensure validity of issue. Needs Wireframe GUI design and mockup needed trust ui Work related to the UI
Projects
None yet
Milestone
No milestone
2 participants
@jw3 @egbicker