Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout action breaks describe #143

Closed
jw3 opened this issue Jun 16, 2021 · 3 comments · Fixed by #144
Closed

Checkout action breaks describe #143

jw3 opened this issue Jun 16, 2021 · 3 comments · Fixed by #144
Labels
bug Something isn't working CI Continuous Integration

Comments

@jw3
Copy link
Member

jw3 commented Jun 16, 2021

Tagged releases are not capturing the right version number from CI.

The describe that is used to generate the version numbers doesnt like this section of the checkout action

/usr/bin/git rev-parse refs/tags/v0.2.0-rc1
  d5b5a08651c653eaa35cca8ba75c093553058cdf
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules origin +8973e4e52a9f3ae149185e2491a084ef3df14f71:refs/tags/v0.2.0-rc1
  From https://github.com/ctc-oss/fapolicy-analyzer
   t [tag update]      8973e4e52a9f3ae149185e2491a084ef3df14f71 -> v0.2.0-rc1

This can be reproduced locally using the same commands that the checkout action uses. I'm not yet sure why the fetch is structured the way it is.

@jw3 jw3 added bug Something isn't working CI Continuous Integration labels Jun 16, 2021
@jw3
Copy link
Member Author

jw3 commented Jun 16, 2021

@jw3
Copy link
Member Author

jw3 commented Jun 16, 2021

@jw3
Copy link
Member Author

jw3 commented Jun 16, 2021

Appears that leaving the ref empty on the checkout was causing this...

Fixed with

      - uses: actions/checkout@v2
        with:
          ref: ${{ github.ref }}
          fetch-depth: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant